netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: <netdev@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	<kvm@vger.kernel.org>, David Miller <davem@davemloft.net>
Subject: Re: Moving frags and SKBTX_DEV_ZEROCOPY skbs
Date: Thu, 15 May 2014 18:14:26 +0100	[thread overview]
Message-ID: <5374F5F2.9000807@citrix.com> (raw)
In-Reply-To: <5373C701.1080301@citrix.com>

On 14/05/14 20:41, Zoltan Kiss wrote:
> But here is the thing: deliver_skb calls orphan_frags for every packet
> delivered to the local stack, so we are safe IF these functions are
> called before the IP stack. So we are safe now, but things can go wrong,
> if:
> - such a frag-mangling function is called before deliver_skb, now or in
> the future
> - if someone wants to take advantage of zerocopy in the guest<->backend
> path

Running through the code I've found the following core functions can 
shuffle frags between skbs (and don't handle zerocopy skbs already):
skb_gro_receive
skb_shift
skb_split

None of them can meet at the moment with zerocopy skbs, but it's better 
to keep it in mind for the future, that would blow up these kind of skbs.

Zoli

      parent reply	other threads:[~2014-05-15 17:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 13:40 Moving frags and SKBTX_DEV_ZEROCOPY skbs Zoltan Kiss
2014-05-14 14:23 ` Eric Dumazet
2014-05-14 17:42   ` David Miller
2014-05-14 17:52     ` Eric Dumazet
2014-05-14 19:41   ` Zoltan Kiss
2014-05-14 19:52     ` Eric Dumazet
2014-05-15 17:14     ` Zoltan Kiss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5374F5F2.9000807@citrix.com \
    --to=zoltan.kiss@citrix.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).