From: Alexander Duyck <alexander.h.duyck@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com, jpirko@redhat.com
Subject: Re: [RFC PATCH] net: Add support for device specific address syncing
Date: Fri, 16 May 2014 15:24:27 -0700 [thread overview]
Message-ID: <5376901B.7040700@intel.com> (raw)
In-Reply-To: <20140516.164728.2297526772904518777.davem@davemloft.net>
On 05/16/2014 01:47 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Fri, 16 May 2014 12:55:42 -0700
>
>> I can understand going into promisc on a sync failure, but why would you
>> do it on an unsync failure, or are you saying that we would be clearing
>> the flag in unsync?
>
> We should clear the promisc flag on unsync if the limitations are no
> longer exceeded.
>
>> In general I intended for this to be called in set_rx_mode so if
>> __dev_uc_sync returns an error indicating insufficient resources we have
>> to force IFF_PROMISC on because adding a new address failed. We could
>> also do the same thing for __dev_mc_sync and IFF_ALLMULTI.
>
> Right.
>
Okay, I think that all works. I'll probably resubmit it next week after
it has gone though a bit more testing.
Thanks,
Alex
prev parent reply other threads:[~2014-05-16 22:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 23:37 [RFC PATCH] net: Add support for device specific address syncing Alexander Duyck
2014-05-16 3:05 ` David Miller
2014-05-16 18:47 ` Alexander Duyck
2014-05-16 19:01 ` David Miller
2014-05-16 19:55 ` Alexander Duyck
2014-05-16 20:47 ` David Miller
2014-05-16 22:24 ` Alexander Duyck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5376901B.7040700@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).