From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP Date: Sun, 18 May 2014 18:08:27 +0800 Message-ID: <5378869B.2070102@gmail.com> References: <5376F2F8.3010603@gmail.com> <20140517.013655.349586284786993619.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: David Miller , Roland Dreier , Sean Hefty , Hal Rosenstock , gxt@mprc.pku.edu.cn, Matan Barak , Or Gerlitz , Eyal Perry , Amir Vadai , Shawn Bohrer , linux-rdma , linux-kernel , "netdev@vger.kernel.org" To: Or Gerlitz Return-path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:57826 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbaERKIT (ORCPT ); Sun, 18 May 2014 06:08:19 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 05/18/2014 03:55 AM, Or Gerlitz wrote: > On Sat, May 17, 2014 at 8:36 AM, David Miller wrote: >> >> From: Chen Gang >> Date: Sat, 17 May 2014 13:26:16 +0800 >> >>> 'struct irq_affinity_notify' and the related functions are only defined >>> when SMP enabled, so at present, mlx4 has to only run under SMP. >>> >>> The related error (allmodconfig under unicore32): >> >> Making the entire driver depend upon SMP is not the answer, > > > Indeed, we would do that just for the relevant portion, > Thank you for your work. And next, when I meet the case like this again, instead of sending patch, I shall send suggestion message to the related members/experts. Thanks. -- Chen Gang Open, share and attitude like air, water and life which God blessed