* [BUG] might sleep functions in atomic context in stmmac_resume()
@ 2014-05-16 23:15 Alexey Khoroshilov
2014-05-19 6:57 ` Giuseppe CAVALLARO
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Khoroshilov @ 2014-05-16 23:15 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: Giuseppe Cavallaro, David S. Miller, netdev@vger.kernel.org,
linux-kernel, ldv-project
There are calls to might sleep functions in atomic context in
stmmac_resume():
- the first one is clk_prepare_enable(priv->stmmac_clk);
- the second one is stmmac_hw_setup()
-> init_dma_desc_rings()
-> stmmac_init_rx_buffers()
-> __netdev_alloc_skb(GFP_KERNEL)
What is the purpose of spin_lock_irqsave(&priv->lock, flags) section?
What does it protect against?
Found by Linux Driver Verification project (linuxtesting.org).
--
Alexey Khoroshilov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [BUG] might sleep functions in atomic context in stmmac_resume()
2014-05-16 23:15 [BUG] might sleep functions in atomic context in stmmac_resume() Alexey Khoroshilov
@ 2014-05-19 6:57 ` Giuseppe CAVALLARO
0 siblings, 0 replies; 2+ messages in thread
From: Giuseppe CAVALLARO @ 2014-05-19 6:57 UTC (permalink / raw)
To: Alexey Khoroshilov, Srinivas Kandagatla
Cc: David S. Miller, netdev@vger.kernel.org, linux-kernel,
ldv-project
Hello Alexey
On 5/17/2014 1:15 AM, Alexey Khoroshilov wrote:
> There are calls to might sleep functions in atomic context in
> stmmac_resume():
> - the first one is clk_prepare_enable(priv->stmmac_clk);
> - the second one is stmmac_hw_setup()
> -> init_dma_desc_rings()
> -> stmmac_init_rx_buffers()
> -> __netdev_alloc_skb(GFP_KERNEL)
>
> What is the purpose of spin_lock_irqsave(&priv->lock, flags) section?
> What does it protect against?
Some part of this driver, especially on PM stuff, has been reworked
time ago.
I have in plan to do further tests and investigations
also to understand and try to solve this kind of issues. I do not
want to see this kind of BUGs. Also I have some other patches on
other pending problem I will submit to be reviewed.
I hope to start doing this task in the incoming days.
BR
peppe
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> --
> Alexey Khoroshilov
> Linux Verification Center, ISPRAS
> web: http://linuxtesting.org
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-19 6:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-16 23:15 [BUG] might sleep functions in atomic context in stmmac_resume() Alexey Khoroshilov
2014-05-19 6:57 ` Giuseppe CAVALLARO
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).