Re: [patch 1/1] lib/test_bpf.c: don't use gcc union shortcut

[Randy Dunlap <rdunlap@infradead.org>]

On 05/22/2014 10:58 AM, Andrew Morton wrote:
> On Thu, 22 May 2014 10:36:40 -0700 Alexei Starovoitov <ast@plumgrid.com> wrote:
> 
>> On Thu, May 22, 2014 at 10:16 AM,  <akpm@linux-foundation.org> wrote:
>>> From: Andrew Morton <akpm@linux-foundation.org>
>>> Subject: lib/test_bpf.c: don't use gcc union shortcut
>>>
>>> Older gcc's (mine is gcc-4.4.4) make a mess of this.
>>>
>>> lib/test_bpf.c:74: error: unknown field 'insns' specified in initializer
>>> lib/test_bpf.c:75: warning: missing braces around initializer
>>> lib/test_bpf.c:75: warning: (near initialization for 'tests[0].<anonymous>.insns[0]')
>>> lib/test_bpf.c:76: error: extra brace group at end of initializer
>>> lib/test_bpf.c:76: error: (near initialization for 'tests[0].<anonymous>')
>>> lib/test_bpf.c:76: warning: excess elements in union initializer
>>> lib/test_bpf.c:76: warning: (near initialization for 'tests[0].<anonymous>')
>>> lib/test_bpf.c:77: error: extra brace group at end of initializer
>>>
>>> Cc: Alexei Starovoitov <ast@plumgrid.com>
>>> Cc: David S. Miller <davem@davemloft.net>
>>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>>
>> I didn't know we still want to support such old versions.
>> gcc 4.4 was released in 2009.
> 
> Well, gcc-4.4 fails but I don't know about later versions.
> 
>> What is the official cutoff for gcc ?
> 
> We're really slack about tracking this.  Documentation/Changes says gcc-3.2!

and <linux/compiler-gcc4.h> has some 4.1 and 4.3 testing (and later)
in it.


-- 
~Randy