From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [RFC iproute2-next 2/5] ss: make tcp_mem long Date: Wed, 2 May 2018 14:08:53 -0700 Message-ID: <537df45c-f5d2-e06a-f66c-fe7cd322a255@gmail.com> References: <20180502202801.5255-1-stephen@networkplumber.org> <20180502202801.5255-3-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Stephen Hemminger , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f194.google.com ([209.85.192.194]:34991 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751234AbeEBVI4 (ORCPT ); Wed, 2 May 2018 17:08:56 -0400 Received: by mail-pf0-f194.google.com with SMTP id j5so12834565pfh.2 for ; Wed, 02 May 2018 14:08:56 -0700 (PDT) In-Reply-To: <20180502202801.5255-3-stephen@networkplumber.org> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/02/2018 01:27 PM, Stephen Hemminger wrote: > The tcp_memory field in /proc/net/sockstat is formatted as > a long value by kernel. Change ss to keep this as full value. > > Signed-off-by: Stephen Hemminger > --- > misc/ss.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/misc/ss.c b/misc/ss.c > index 22c76e34f83b..c88a25581755 100644 > --- a/misc/ss.c > +++ b/misc/ss.c > @@ -4589,7 +4589,7 @@ static int get_snmp_int(const char *proto, const char *key, int *result) > > struct ssummary { > int socks; > - int tcp_mem; > + long tcp_mem; > int tcp_total; > int tcp_orphans; > int tcp_tws; > @@ -4629,7 +4629,7 @@ static void get_sockstat_line(char *line, struct ssummary *s) > else if (strcmp(id, "FRAG6:") == 0) > sscanf(rem, "%*s%d%*s%d", &s->frag6, &s->frag6_mem); > else if (strcmp(id, "TCP:") == 0) > - sscanf(rem, "%*s%d%*s%d%*s%d%*s%d%*s%d", > + sscanf(rem, "%*s%d%*s%d%*s%d%*s%d%*s%ld", > &s->tcp4_hashed, > &s->tcp_orphans, &s->tcp_tws, &s->tcp_total, &s->tcp_mem); > } > Hi Stephen It seems nothing uses yet the value ? Also, do we care of iproute2 being compiled in 32bit mode, but eventually running on 64bit kernel ?