From: Amir Vadai <amirv.mellanox@gmail.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Ben Hutchings <ben@decadent.org.uk>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
idos@mellanox.com, Yevgeny Petrilin <yevgenyp@mellanox.com>
Subject: Re: Extend irq_set_affinity_notifier() to use a call chain
Date: Mon, 26 May 2014 14:24:34 +0300 [thread overview]
Message-ID: <53832472.7070000@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405261313570.21720@ionos.tec.linutronix.de>
On 5/26/2014 2:15 PM, Thomas Gleixner wrote:
> On Sun, 25 May 2014, Amir Vadai wrote:
>> In order to do that, I need to add a new irq affinity notification
>> callback (In addition to the existing cpu_rmap notification). For
>> that I would like to extend irq_set_affinity_notifier() to have a
>> notifier call-chain instead of a single notifier callback.
>
> Why? "I would like" is a non argument.
Current implementation enables only one callback to be registered for
irq affinity change notifications.
cpu_rmap is registered be notified - for RFS purposes.
mlx4_en (and probably other network drivers) needs to be notified too,
in order to stop the napi polling on the old cpu and move to the new one.
To enable more than 1 notification callbacks, I suggest to use a
notifier call chain.
Amir
>
> Thanks,
>
> tglx
>
next prev parent reply other threads:[~2014-05-26 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 12:15 Extend irq_set_affinity_notifier() to use a call chain Amir Vadai
2014-05-25 13:05 ` Amir Vadai
2014-05-26 11:15 ` Thomas Gleixner
2014-05-26 11:24 ` Amir Vadai [this message]
2014-05-26 11:34 ` Thomas Gleixner
2014-05-26 12:01 ` Amir Vadai
2014-05-26 12:39 ` Thomas Gleixner
2014-05-27 8:15 ` Amir Vadai
2014-05-27 10:10 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53832472.7070000@gmail.com \
--to=amirv.mellanox@gmail.com \
--cc=amirv@mellanox.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=idos@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=tglx@linutronix.de \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).