From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [PATCH 1/1] iproute2 bridge: bring to par with brctl show macs Date: Tue, 27 May 2014 17:41:06 -0400 Message-ID: <53850672.1030107@mojatatu.com> References: <1401024151-8774-1-git-send-email-jhs@emojatatu.com> <27A51C19-553E-4BA0-A8B2-F4251FABA5F4@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , netdev , Vlad Yasevich , john.r.fastabend@intel.com, Roopa Prabhu To: Scott Feldman Return-path: Received: from mail-ie0-f181.google.com ([209.85.223.181]:37676 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751738AbaE0VlR (ORCPT ); Tue, 27 May 2014 17:41:17 -0400 Received: by mail-ie0-f181.google.com with SMTP id rp18so7962880iec.12 for ; Tue, 27 May 2014 14:41:17 -0700 (PDT) In-Reply-To: <27A51C19-553E-4BA0-A8B2-F4251FABA5F4@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On 05/27/14 11:59, Scott Feldman wrote: > > > Seems you could use your new kernel filter for brports also, when br is not specified. >If both br and brport is specified, then use filter in user-space, otherwise use filter >in kernel on br or brport ifindex. > filtering by brport is very useful. I wasnt as much concerned about that use case because i can already filter in user space for brport when i dump (iproute2 does as well). But i couldnt filter by bridge since that info is not even present in the dumped data I just saw the patch posted by Roopa - I think that now gives me the ability to also filter by bridge in user space. Note: All i am doing is stealing the ndm ifindex - which before was a zero and ignore by the kernel as the bridge ifindex. I think what you are suggesting is: if the user doesnt specify the bridge i should use the ndm ifindex to send down the brport as the filter. But that becomes an bridge "or" bridgeport filter choice. A more useful scenario is to have bridge "and" bridgeport filter. So almost seems like i need an attribute to send down for the bridge port. Sounds like a separate patch... cheers, jamal