From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [RFC PATCH] Add bridge ifindex to bridge fdb notify msgs Date: Tue, 27 May 2014 17:57:13 -0400 Message-ID: <53850A39.5060406@mojatatu.com> References: <1401165586-13836-1-git-send-email-roopa@cumulusnetworks.com> <20140527093713.512824b0@nehalam.linuxnetplumber.net> <5384C5C6.2090606@cumulusnetworks.com> <538508D0.5050405@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, wkok@cumulusnetworks.com, Shrijeet Mukherjee To: Roopa Prabhu , Stephen Hemminger Return-path: Received: from mail-ie0-f179.google.com ([209.85.223.179]:62437 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751833AbaE0V5P (ORCPT ); Tue, 27 May 2014 17:57:15 -0400 Received: by mail-ie0-f179.google.com with SMTP id rd18so9206241iec.24 for ; Tue, 27 May 2014 14:57:15 -0700 (PDT) In-Reply-To: <538508D0.5050405@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: Just to be clear - I meant i dont see its usefulness in a set (definitely useful in notify and get/dump). cheers, jamal On 05/27/14 17:51, Jamal Hadi Salim wrote: > I think it is useful for symettry purposes to have both directions > have NDA_MASTER; but other than that, I dont see any purpose NDA_MASTER > serves. A bridge port is specified on the ndm msg to the kernel. > A bridge port can only belong to one master. > The kernel can deduce that already. > Infact i think specifying the NDA_MASTER may cause problems when > the specified NDA_MASTER is not the bridge to which the bridge port > belongs to.... > > cheers, > jamal >