From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42223C433E3 for ; Fri, 17 Jul 2020 20:44:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24FC420684 for ; Fri, 17 Jul 2020 20:44:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728455AbgGQUon (ORCPT ); Fri, 17 Jul 2020 16:44:43 -0400 Received: from nbd.name ([46.4.11.11]:53086 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726492AbgGQUon (ORCPT ); Fri, 17 Jul 2020 16:44:43 -0400 Received: from [2a04:4540:1402:e200:f4bc:edb0:b75b:df61] by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jwXDQ-0005hg-CH; Fri, 17 Jul 2020 22:44:20 +0200 Subject: Re: [PATCH 2/2] dt-bindings: net: dsa: qca8k: Add PORT0_PAD_CTRL properties To: Matthew Hagan , Jakub Kicinski , Andrew Lunn Cc: Vivien Didelot , Florian Fainelli , "David S. Miller" , linux@armlinux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan McDowell , Rob Herring , devicetree@vger.kernel.org References: <2e1776f997441792a44cd35a16f1e69f848816ce.1594668793.git.mnhagan88@gmail.com> <20200716150925.0f3e01b8@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: John Crispin Message-ID: <53851852-0efe-722e-0254-8652cdfea8fc@phrozen.org> Date: Fri, 17 Jul 2020 22:44:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 17.07.20 22:29, Matthew Hagan wrote: > > On 16/07/2020 23:09, Jakub Kicinski wrote: >> On Mon, 13 Jul 2020 21:50:26 +0100 Matthew Hagan wrote: >>> Add names and decriptions of additional PORT0_PAD_CTRL properties. >>> >>> Signed-off-by: Matthew Hagan >>> --- >>> Documentation/devicetree/bindings/net/dsa/qca8k.txt | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/dsa/qca8k.txt b/Documentation/devicetree/bindings/net/dsa/qca8k.txt >>> index ccbc6d89325d..3d34c4f2e891 100644 >>> --- a/Documentation/devicetree/bindings/net/dsa/qca8k.txt >>> +++ b/Documentation/devicetree/bindings/net/dsa/qca8k.txt >>> @@ -13,6 +13,14 @@ Optional properties: >>> >>> - reset-gpios: GPIO to be used to reset the whole device >>> >>> +Optional MAC configuration properties: >>> + >>> +- qca,exchange-mac0-mac6: If present, internally swaps MAC0 and MAC6. >> Perhaps we can say a little more here? >> > From John's patch: > "The switch allows us to swap the internal wirering of the two cpu ports. > For the HW offloading to work the ethernet MAC conencting to the LAN > ports must be wired to cpu port 0. There is HW in the wild that does not > fulfill this requirement. On these boards we need to swap the cpu ports." > > This option is somewhat linked to instances where both MAC0 and MAC6 are > used as CPU ports. I may omit this for now since support for this hasn't > been added and MAC0 is hard-coded as the CPU port. The initial intention > here was to cover options commonly set by OpenWrt devices, based upon > their ar8327-initvals, to allow migration to qca8k. > > correct, specifically quantenna designs do this, also saw ciscos swap mac0/6 for cpu port, that part of the patch is definitely safe to go. I stumbled across this while making qca8k work for g-fiber on a quantenna SoC. in regards to the sgmii clk skew. I never understood the electrics fully I am afraid, but without the patch it simply does not work. my eletcric foo is unfortunately is not sufficient to understand the "whys" I am afraid.     John