netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: mtk.manpages@gmail.com, lkml <linux-kernel@vger.kernel.org>,
	"linux-man@vger.kernel.org" <linux-man@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"Ondřej Bílka" <neleai@seznam.cz>,
	"Caitlin Bestler" <caitlin.bestler@gmail.com>,
	"Neil Horman" <nhorman@tuxdriver.com>,
	"Elie De Brauwer" <eliedebrauwer@gmail.com>,
	"David Miller" <davem@davemloft.net>,
	"Steven Whitehouse" <steve@chygwyn.com>,
	"Rémi Denis-Courmont" <remi.denis-courmont@nokia.com>,
	"Paul Moore" <paul@paul-moore.com>,
	"Chris Friesen" <chris.friesen@windriver.com>
Subject: Re: [PATCH/RFC] Re: recvmmsg() timeout behavior strangeness [RESEND]
Date: Wed, 28 May 2014 07:00:01 +0200	[thread overview]
Message-ID: <53856D51.40304@gmail.com> (raw)
In-Reply-To: <20140527203010.GA2764@kernel.org>

On 05/27/2014 10:30 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 27, 2014 at 09:28:37PM +0200, Michael Kerrisk (man-pages) escreveu:
>> On Tue, May 27, 2014 at 9:21 PM, Arnaldo Carvalho de Melo
>> <acme@ghostprotocols.net> wrote:
>>> Em Tue, May 27, 2014 at 06:35:17PM +0200, Michael Kerrisk (man-pages) escreveu:
>>>> On 05/26/2014 11:17 PM, Arnaldo Carvalho de Melo wrote:
>>>>> Can you try the attached patch on top of the first one?
>>>
>>>> Patches on patches is a way to make your testers work unnecessarily
>>>> harder. Also, it means that anyone else who was interested in this
>>>
>>> It was meant to highlight the changes with regard to the previous patch,
>>> i.e. to make things easier for reviewing.
>>
>> (I don't think that works...)
> 
> Lets try both then, attached goes the updated patch, and this is the
> diff to the last combined one:

What tree does this apply to? I tried applying to 3.15-rc7, but a piece 
was rejected, and the fix was not obvious.

Cheers,

Michael


drivers/net/tun.c.rej

--- drivers/net/tun.c
+++ drivers/net/tun.c
@@ -1343,7 +1343,7 @@
 
        /* Read frames from queue */
        skb = __skb_recv_datagram(tfile->socket.sk, noblock ? MSG_DONTWAIT : 0,
-                                 &peeked, &off, &err);
+                                 &peeked, &off, &err, timeop);
        if (skb) {
                ret = tun_put_user(tun, tfile, skb, iv, len);
                kfree_skb(skb);

  reply	other threads:[~2014-05-28  5:00 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-30 13:59 recvmmsg() timeout behavior strangeness [RESEND] Michael Kerrisk (man-pages)
     [not found] ` <536101C9.9090601-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-03 10:28   ` Michael Kerrisk (man-pages)
2014-05-03 11:29     ` Florian Westphal
2014-05-03 11:39       ` Michael Kerrisk (man-pages)
2014-05-12 10:15 ` Michael Kerrisk (man-pages)
2014-05-12 14:34   ` Arnaldo Carvalho de Melo
     [not found]     ` <20140512143451.GB13801-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-21 21:05       ` [PATCH/RFC] " Arnaldo Carvalho de Melo
     [not found]         ` <20140521210535.GA5414-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-22 14:27           ` Michael Kerrisk (man-pages)
2014-05-24  6:13             ` Michael Kerrisk (man-pages)
2014-05-26 13:46             ` Arnaldo Carvalho de Melo
     [not found]               ` <20140526134647.GB8176-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-26 21:17                 ` Arnaldo Carvalho de Melo
2014-05-27 16:35                   ` Michael Kerrisk (man-pages)
     [not found]                     ` <5384BEC5.2080607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-05-27 19:21                       ` Arnaldo Carvalho de Melo
     [not found]                         ` <20140527192115.GD25474-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-27 19:22                           ` Arnaldo Carvalho de Melo
2014-05-27 19:28                           ` Michael Kerrisk (man-pages)
     [not found]                             ` <CAKgNAkht1vubHueYPpkRu_W5B8OYW3rPUkHeLEq5WMVbCvO47w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-27 20:30                               ` Arnaldo Carvalho de Melo
2014-05-28  5:00                                 ` Michael Kerrisk (man-pages) [this message]
     [not found]                                 ` <20140527203010.GA2764-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-28 12:20                                   ` Michael Kerrisk (man-pages)
2014-05-28 15:07                                     ` Arnaldo Carvalho de Melo
     [not found]                                       ` <20140528150720.GB2764-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-28 15:17                                         ` David Laight
2014-05-28 19:50                                           ` 'Arnaldo Carvalho de Melo'
     [not found]                                             ` <20140528195004.GD2764-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-28 21:33                                               ` Chris Friesen
2014-05-28 21:49                                                 ` 'Arnaldo Carvalho de Melo'
2014-05-29 10:53                                             ` David Laight
2014-05-29 13:55                                               ` 'Arnaldo Carvalho de Melo'
2014-05-29 14:06                                                 ` David Laight
2014-05-29 14:17                                                   ` 'Arnaldo Carvalho de Melo'
     [not found]                                                     ` <20140529141705.GI2764-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-29 14:40                                                       ` David Laight
2014-05-29 15:33                                                     ` [PATCH/RFC] Handle EFAULT in partial recvmmsg was " 'Arnaldo Carvalho de Melo'
2014-06-16  9:58                                                     ` Michael Kerrisk (man-pages)
     [not found]                                                       ` <CAKgNAkj-MVfeqEeffWKMNok0yO-Rm1kyY+zhXEy-U9NkB+aLow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-24 20:25                                                         ` Arnaldo Carvalho de Melo
     [not found]                                                           ` <20140624202541.GD3456-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-06-27 11:29                                                             ` Michael Kerrisk (man-pages)
2014-05-29 14:07                                               ` Michael Kerrisk (man-pages)
     [not found]                                     ` <5385D47A.3070401-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-06-27 11:37                                       ` Michael Kerrisk (man-pages)
2014-05-23 19:00           ` David Miller
     [not found]             ` <20140523.150055.2214666905697701415.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-05-23 19:55               ` Arnaldo Carvalho de Melo
     [not found]                 ` <20140523195522.GH2741-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2014-05-24  6:13                   ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53856D51.40304@gmail.com \
    --to=mtk.manpages@gmail.com \
    --cc=acme@kernel.org \
    --cc=caitlin.bestler@gmail.com \
    --cc=chris.friesen@windriver.com \
    --cc=davem@davemloft.net \
    --cc=eliedebrauwer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=neleai@seznam.cz \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=paul@paul-moore.com \
    --cc=remi.denis-courmont@nokia.com \
    --cc=steve@chygwyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).