From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Ondrej Zary <linux@rainbow-software.org>,
Samuel Chessman <chessman@tux.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 7/9] tlan: Make autonegotiation faster
Date: Wed, 28 May 2014 18:11:06 +0400 [thread overview]
Message-ID: <5385EE7A.2030501@cogentembedded.com> (raw)
In-Reply-To: <1401226727-5508-8-git-send-email-linux@rainbow-software.org>
Hello.
On 05/28/2014 01:38 AM, Ondrej Zary wrote:
> Reduce the autonegotiation poll interval from 8 seconds to 2.
> This greatly reduces the time needed to detect link presence,
> especially on Olicom cards at 10 Mbps (two autonegoatiations required).
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> ---
> drivers/net/ethernet/ti/tlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/drivers/net/ethernet/ti/tlan.c b/drivers/net/ethernet/ti/tlan.c
> index 628a779..007c2fe 100644
> --- a/drivers/net/ethernet/ti/tlan.c
> +++ b/drivers/net/ethernet/ti/tlan.c
> @@ -2699,7 +2699,7 @@ static void tlan_phy_finish_auto_neg(struct net_device *dev)
> /* Wait for 8 sec to give the process
> * more time. Perhaps we should fail after a while.
> */
> - tlan_set_timer(dev, (8*HZ), TLAN_TIMER_PHY_FINISH_AN);
> + tlan_set_timer(dev, (2*HZ), TLAN_TIMER_PHY_FINISH_AN);
The inner () not needed but space around * wouldn't hurt.
> return;
> }
WBR, Sergei
next prev parent reply other threads:[~2014-05-28 14:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 21:38 [PATCH 0/9] tlan: Link handling improvements and Olicom fixes Ondrej Zary
2014-05-27 21:38 ` [PATCH 1/9] tlan: Enable activity LED on Olicom OC-2325 and OC-2326 Ondrej Zary
2014-05-27 21:38 ` [PATCH 2/9] tlan: Enable link monitoring Ondrej Zary
2014-05-27 21:38 ` [PATCH 3/9] tlan: Add ethtool support Ondrej Zary
2014-05-27 21:38 ` [PATCH 4/9] tlan: Fix MAC address byte order on OC-2325/OC-2326 Ondrej Zary
2014-05-27 21:38 ` [PATCH 5/9] tlan: Restart autonegotiation on link loss Ondrej Zary
2014-05-27 22:29 ` Florian Fainelli
2014-05-28 6:39 ` Ondrej Zary
2014-05-28 17:26 ` Florian Fainelli
2014-05-28 14:08 ` Sergei Shtylyov
2014-05-27 21:38 ` [PATCH 6/9] tlan: Don't scream if no link Ondrej Zary
2014-05-27 21:38 ` [PATCH 7/9] tlan: Make autonegotiation faster Ondrej Zary
2014-05-28 14:11 ` Sergei Shtylyov [this message]
2014-05-27 21:38 ` [PATCH 8/9] tlan: Add PHY reset timeout Ondrej Zary
2014-05-27 21:38 ` [PATCH 9/9] tlan: Don't disable internal PHY on cards that use it in 10 Mbps mode Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5385EE7A.2030501@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=chessman@tux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).