From: Vlad Yasevich <vyasevich@gmail.com>
To: Ding Tianhong <dingtianhong@huawei.com>,
kaber@trash.net, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode
Date: Wed, 28 May 2014 12:24:05 -0400 [thread overview]
Message-ID: <53860DA5.8090407@gmail.com> (raw)
In-Reply-To: <1401106233-11320-1-git-send-email-dingtianhong@huawei.com>
On 05/26/2014 08:10 AM, Ding Tianhong wrote:
> Ding Tianhong (2):
> macvlan: don't change macvlan address alone for passthru mode
> macvlan: propagate lowerdev mac address changes for passthru mode
>
> drivers/net/macvlan.c | 40 +++++++++++++++++++++++++++++++---------
> 1 file changed, 31 insertions(+), 9 deletions(-)
>
This ends up working kind-of backwards... A user now has to know
that passthru macvlans he has to change the lower-level mac, but
for all others, changing the macvlan mac is ok and will work...
This also will not work if the passthru macvlan is stacked on
something other the hw (for example: a vlan).
Why not simply propagate the mac address change of the passhtru macvlan
down to the real device?
Thanks
-vlad
next prev parent reply other threads:[~2014-05-28 16:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 12:10 [PATCH net-next 0/2] macvlan: fix the problem when mac address changes for passthru mode Ding Tianhong
2014-05-26 12:10 ` [PATCH net-next 1/2] macvlan: don't change macvlan address alone " Ding Tianhong
2014-05-26 12:10 ` [PATCH net-next 2/2] macvlan: propagate lowerdev mac address changes " Ding Tianhong
2014-05-28 16:24 ` Vlad Yasevich [this message]
2014-05-29 3:29 ` [PATCH net-next 0/2] macvlan: fix the problem when " Ding Tianhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53860DA5.8090407@gmail.com \
--to=vyasevich@gmail.com \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).