From: Yang Yingliang <yangyingliang@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Eric Dumazet <eric.dumazet@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2 v3] fq: allow options of fair queue set to ~0U
Date: Thu, 29 May 2014 10:43:33 +0800 [thread overview]
Message-ID: <53869ED5.1090903@huawei.com> (raw)
In-Reply-To: <20140528170957.19b50c12@nehalam.linuxnetplumber.net>
On 2014/5/29 8:09, Stephen Hemminger wrote:
> On Tue, 13 May 2014 12:20:52 +0800
> Yang Yingliang <yangyingliang@huawei.com> wrote:
>
>> + int set_plimit = 0;
>> + int set_flow_plimit = 0;
>> + int set_quantum = 0;
>> + int set_initial_quantum = 0;
>> + int set_maxrate = 0;
>> + int set_defrate = 0;
>
> Please use bool for these since they are boolean flags.
>
>
OK, I'll send a v3 later.
next prev parent reply other threads:[~2014-05-29 2:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 4:18 [PATCH iproute2] fq: don't allow set options to zero Yang Yingliang
2014-05-12 5:58 ` Eric Dumazet
2014-05-12 6:51 ` Yang Yingliang
2014-05-12 6:55 ` Yang Yingliang
2014-05-12 6:59 ` Yang Yingliang
2014-05-12 15:23 ` Eric Dumazet
2014-05-13 2:23 ` [PATCH iproute2 v2] fq: allow options of fair queue set to ~0U Yang Yingliang
2014-05-13 3:03 ` Eric Dumazet
2014-05-13 4:10 ` Yang Yingliang
2014-05-13 4:20 ` [PATCH iproute2 v3] " Yang Yingliang
2014-05-29 0:09 ` Stephen Hemminger
2014-05-29 2:43 ` Yang Yingliang [this message]
2014-05-29 4:04 ` [PATCH iproute2 v4] " Yang Yingliang
2014-06-09 19:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53869ED5.1090903@huawei.com \
--to=yangyingliang@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).