From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] sh_eth: use RNC mode for R8A7790 Date: Fri, 30 May 2014 18:00:10 +0400 Message-ID: <53888EEA.7060702@cogentembedded.com> References: <1401458186-29985-1-git-send-email-ben.dooks@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel@codethink.co.uk, nobuhiro.iwamatsu.yj@renesas.com, magnus.damn@opensource.se, horms@verge.net.au To: Ben Dooks , netdev@vger.kernel.org Return-path: Received: from mail-la0-f49.google.com ([209.85.215.49]:33633 "EHLO mail-la0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755928AbaE3OAH (ORCPT ); Fri, 30 May 2014 10:00:07 -0400 Received: by mail-la0-f49.google.com with SMTP id pv20so1019067lab.8 for ; Fri, 30 May 2014 07:00:05 -0700 (PDT) In-Reply-To: <1401458186-29985-1-git-send-email-ben.dooks@codethink.co.uk> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 05/30/2014 05:56 PM, Ben Dooks wrote: The subject should have "R8A779x". > The current behaviour of the sh_eth driver is not to use the RNC bit > for the receive ring. This means that every packet recieved is not only > generating an IRQ but it also stops the receive ring DMA as well until > the driver re-enables it after unloading the packet. > > This means that a number of the following errors are generated due to > the receive packet FIFO overflowing due to nowhere to put packets: > > net eth0: Receive FIFO Overflow > > Setting the RMCR_RNC configuration has so far been tested with an NFS > root filesystem and the driver has not failed yet. It is not yet known > why this is not set for R8A779x operation (Feedback on this issue or > other testing is welcome) I have provided such feedback (and many people provided testing), so that the last sentence doesn't make sense anymore. > There are further test reports from Sergei Shtylov and others for > both the R8A7790 and R8A7791. > Tested-by: Sergei Shtylyov > Signed-off-by: Ben Dooks Other than the remarks above: Acked-by: Sergei Shtylyov WBR, Sergei