From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
netdev@vger.kernel.org
Cc: linux-kernel@codethink.co.uk, nobuhiro.iwamatsu.yj@renesas.com,
magnus.damn@opensource.se, horms@verge.net.au
Subject: Re: [PATCH] sh_eth: use RNC mode for R8A7790
Date: Fri, 30 May 2014 15:09:54 +0100 [thread overview]
Message-ID: <53889132.7020104@codethink.co.uk> (raw)
In-Reply-To: <53888EEA.7060702@cogentembedded.com>
On 30/05/14 15:00, Sergei Shtylyov wrote:
> Hello.
>
> On 05/30/2014 05:56 PM, Ben Dooks wrote:
>
> The subject should have "R8A779x".
>
>> The current behaviour of the sh_eth driver is not to use the RNC bit
>> for the receive ring. This means that every packet recieved is not only
>> generating an IRQ but it also stops the receive ring DMA as well until
>> the driver re-enables it after unloading the packet.
>>
>> This means that a number of the following errors are generated due to
>> the receive packet FIFO overflowing due to nowhere to put packets:
>>
>> net eth0: Receive FIFO Overflow
>>
>> Setting the RMCR_RNC configuration has so far been tested with an NFS
>> root filesystem and the driver has not failed yet. It is not yet known
>> why this is not set for R8A779x operation (Feedback on this issue or
>> other testing is welcome)
>
> I have provided such feedback (and many people provided testing), so
> that the last sentence doesn't make sense anymore.
I suppose it could be removed, it depends on how pedantic people
want to be with the changelogs.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2014-05-30 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-30 13:56 [PATCH] sh_eth: use RNC mode for R8A7790 Ben Dooks
2014-05-30 14:00 ` Sergei Shtylyov
2014-05-30 14:09 ` Ben Dooks [this message]
2014-05-31 0:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53889132.7020104@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=horms@verge.net.au \
--cc=linux-kernel@codethink.co.uk \
--cc=magnus.damn@opensource.se \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).