From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Subject: Re: [PATCH 2/11] cw1200: Remove useless return variables Date: Sat, 31 May 2014 17:17:52 +0200 Message-ID: <5389F2A0.1000903@bfs.de> References: <1401542051-3174-2-git-send-email-peter.senna@gmail.com> Reply-To: wharms-fPG8STNUNVg@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Solomon Peachy , kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "John W. Linville" , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Senna Tschudin Return-path: In-Reply-To: <1401542051-3174-2-git-send-email-peter.senna-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Am 31.05.2014 15:14, schrieb Peter Senna Tschudin: > This patch remove variables that are initialized with a constant, > are never updated, and are only used as parameter of return. > Return the constant instead of using a variable. > > Verified by compilation only. > > The coccinelle script that find and fixes this issue is: > // > @@ > type T; > constant C; > identifier ret; > @@ > - T ret = C; > ... when != ret > when strict > return > - ret > + C > ; > // > > Signed-off-by: Peter Senna Tschudin > > --- > drivers/net/wireless/cw1200/sta.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) > > diff --git a/drivers/net/wireless/cw1200/sta.c b/drivers/net/wireless/cw1200/sta.c > index cd0cad7..622370c 100644 > --- a/drivers/net/wireless/cw1200/sta.c > +++ b/drivers/net/wireless/cw1200/sta.c > @@ -2289,24 +2289,7 @@ static int cw1200_upload_null(struct cw1200_common *priv) > > static int cw1200_upload_qosnull(struct cw1200_common *priv) > { > - int ret = 0; > - /* TODO: This needs to be implemented > - > - struct wsm_template_frame frame = { > - .frame_type = WSM_FRAME_TYPE_QOS_NULL, > - .rate = 0xFF, > - }; > - > - frame.skb = ieee80211_qosnullfunc_get(priv->hw, priv->vif); > - if (!frame.skb) > - return -ENOMEM; > - > - ret = wsm_set_template_frame(priv, &frame); > - > - dev_kfree_skb(frame.skb); > - > - */ > - return ret; > + return 0; > } > > static int cw1200_enable_beaconing(struct cw1200_common *priv, are you sure you want to remove the entire function ? re, wh > > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html