netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Wei Yang <weiyang@linux.vnet.ibm.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
	Amir Vadai <amirv@mellanox.com>,
	Jack Morgenstein <jackm@dev.mellanox.co.il>
Subject: Re: [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()
Date: Sun, 1 Jun 2014 12:36:18 +0300	[thread overview]
Message-ID: <538AF412.9080406@mellanox.com> (raw)
In-Reply-To: <538AF2CB.20603@mellanox.com>

On 01/06/2014 12:30, Or Gerlitz wrote:
> Wait, I recently noticed that on 3.15-rcX if the host is rebooted when 
> the mlx4_core driver is loaded in SRIOV mode, we crash like that, 
> looking on this now, I think there's chance we can relate it to your 
> upstream change befdf89 "net/mlx4_core: Preserve pci_dev_data after 
> __mlx4_remove_one()"

this seems to fix the crash, will further evaluate and submit patch 
later today



index c187d74..c747736 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2629,7 +2629,7 @@ static void __mlx4_remove_one(struct pci_dev *pdev)
         int               pci_dev_data;
         int p;

-       if (priv->removed)
+       if (!priv || priv->removed)
                 return;

         pci_dev_data = priv->pci_dev_data;

  reply	other threads:[~2014-06-01  9:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-01  7:24 [PATCH 3.14-stable] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one() Wei Yang
2014-06-01  7:38 ` Wei Yang
2014-06-01  9:30   ` Or Gerlitz
2014-06-01  9:36     ` Or Gerlitz [this message]
2014-06-01 10:52       ` Or Gerlitz
2014-06-02 13:53     ` Wei Yang
2014-06-03  8:43       ` Or Gerlitz
2014-06-04  1:44         ` Wei Yang
2014-06-17  2:49 ` Wei Yang
2014-06-17  3:03   ` David Miller
2014-06-17  3:08     ` Wei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538AF412.9080406@mellanox.com \
    --to=ogerlitz@mellanox.com \
    --cc=amirv@mellanox.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=jackm@dev.mellanox.co.il \
    --cc=netdev@vger.kernel.org \
    --cc=weiyang@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).