From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Or Gerlitz <ogerlitz@mellanox.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, amirv@mellanox.com,
weiyang@linux.vnet.ibm.com,
Jack Morgenstein <jackm@dev.mellanox.co.il>
Subject: Re: [PATCH net] net/mlx4_core: Fix Oops on reboot when SRIOV VFs are probed into the Host
Date: Sun, 01 Jun 2014 20:41:31 +0400 [thread overview]
Message-ID: <538B57BB.5090000@cogentembedded.com> (raw)
In-Reply-To: <1401619783-23659-1-git-send-email-ogerlitz@mellanox.com>
Hello.
On 06/01/2014 02:49 PM, Or Gerlitz wrote:
> From: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Commit befdf89 did not take into account the case where the Host
Please also specify that commit's summary line in parens.
> driver is being unloaded. In this case, pci_get_drvdata for the VF
> remove_one call may return NULL, so that dereferencing the priv
> struct results in a kernel oops.
> The fix is to also test that the dev pointer returned by
> pci_get_drvdata is non-NULL.
> Fixes: befdf89 ("preserve pcd_dev_data after __mlx4_remove_one()")
> Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
> Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
WBR, Sergei
next prev parent reply other threads:[~2014-06-01 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 10:49 [PATCH net] net/mlx4_core: Fix Oops on reboot when SRIOV VFs are probed into the Host Or Gerlitz
2014-06-01 16:41 ` Sergei Shtylyov [this message]
2014-06-01 19:59 ` Or Gerlitz
2014-06-02 14:29 ` Wei Yang
2014-06-02 16:10 ` Bjorn Helgaas
2014-06-03 0:58 ` David Miller
2014-06-03 2:00 ` Wei Yang
2014-06-03 8:15 ` Or Gerlitz
2014-06-03 8:40 ` Wei Yang
2014-06-04 9:50 ` Wei Yang
2014-06-06 2:52 ` Wei Yang
2014-06-08 9:18 ` Or Gerlitz
2014-06-08 9:16 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538B57BB.5090000@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=jackm@dev.mellanox.co.il \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=weiyang@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).