From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Chaoming Li <chaoming_li@realsil.com.cn>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Network Development <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variables
Date: Sun, 01 Jun 2014 23:32:27 +0400 [thread overview]
Message-ID: <538B7FCB.5090106@cogentembedded.com> (raw)
In-Reply-To: <CAFo99gYJ_K9qEaHihtvaFT4Wv3ApUZMJmTK=nuqK+=sA2NaYsA@mail.gmail.com>
Hello.
On 06/01/2014 08:44 PM, Rickard Strandqvist wrote:
> Okay, sorry. But you agree with what it is doing in general then?
Now that you asked, I do agree. But generally my reply doesn't mean that I
went and studied the patch context and verified that the patch is indeed correct.
> In this case, I am sending a new patch...
BTW, it's worth mentioning in the change log that you're moving the
variable in question into the block.
> Best regards
> Rickard Strandqvist
WBR, Sergei
prev parent reply other threads:[~2014-06-01 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 12:49 [PATCH] net: wireless: rtlwifi: rtl8192de: phy.c: Cleaning up uninitialized variables Rickard Strandqvist
2014-06-01 16:38 ` Sergei Shtylyov
2014-06-01 16:44 ` Rickard Strandqvist
2014-06-01 19:32 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538B7FCB.5090106@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Larry.Finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).