From: Amir Vadai <amirv@mellanox.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: <ogerlitz@mellanox.com>, <netdev@vger.kernel.org>,
<yevgenyp@mellanox.com>, <yuvala@mellanox.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint
Date: Mon, 2 Jun 2014 17:08:20 +0300 [thread overview]
Message-ID: <538C8554.8070109@mellanox.com> (raw)
In-Reply-To: <1401685992.3645.173.camel@edumazet-glaptop2.roam.corp.google.com>
On 6/2/2014 8:13 AM, Eric Dumazet wrote:
> On Sun, 2014-06-01 at 21:56 -0700, David Miller wrote:
>
>> Indeed you have to provide a dummy version for a non-SMP build etc.
>>
>> I'm reverting.
>>
>
> Hi David. I think your revert took one wrong commit.
>
>
> # git show ee39facbf82e73e468c504d2b40e83e2d223c28c | diffstat -p1 -w70
> drivers/net/ethernet/micrel/ks8851.c | 50 ++++++++++---------
> include/linux/cpumask.h | 2
> lib/cpumask.c | 64 -------------------------
> 3 files changed, 28 insertions(+), 88 deletions(-)
>
>
>
Hi,
Yeh, Eric is right and it seems that 2a82e40 "net: ks8851: Don't use
regulator_get_optional()" was reverted by mistake instead of 70a640d:
"net/mlx4_en: Use affinity hint"
I'm working on a fixed version of the affinity patches - this time I
will double check the CONFIG_SMP/CONFIG_CPUMASK_OFFSTACK combinations.
I'm preparing a public git with Mellanox updates, so that Mellanox
drivers patches will pass 0-DAY kernel build testing, before landing in
net-next.
Amir
next prev parent reply other threads:[~2014-06-02 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-25 14:47 [PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function Amir Vadai
2014-05-25 14:47 ` [PATCH net-next V6 1/2] cpumask: Utility function to set n'th cpu - local cpu first Amir Vadai
2014-05-27 19:24 ` David Miller
2014-05-28 5:49 ` Or Gerlitz
2014-05-25 14:47 ` [PATCH net-next V6 2/2] net/mlx4_en: Use affinity hint Amir Vadai
2014-06-02 4:16 ` Eric Dumazet
2014-06-02 4:37 ` Eric Dumazet
2014-06-02 4:56 ` David Miller
2014-06-02 5:13 ` Eric Dumazet
2014-06-02 7:10 ` David Miller
2014-06-02 14:08 ` Amir Vadai [this message]
2014-06-02 4:54 ` David Miller
2014-06-02 2:17 ` [PATCH net-next V6 0/2] cpumask,net: Affinity hint helper function David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538C8554.8070109@mellanox.com \
--to=amirv@mellanox.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.com \
--cc=yuvala@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).