From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: ben.dooks@codethink.co.uk, linux-kernel@codethink.co.uk,
netdev@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com,
magnus.damn@opensource.se, horms@verge.net.au,
yoshihiro.shimoda.uh@renesas.com, cm-hiep@jinso.co.jp
Subject: Re: [PATCH v2] sh_eth: use RNC mode for R8A7790/R87791
Date: Tue, 03 Jun 2014 00:55:38 +0400 [thread overview]
Message-ID: <538CE4CA.4090301@cogentembedded.com> (raw)
In-Reply-To: <20140602.134915.1162774321657125992.davem@davemloft.net>
On 06/03/2014 12:49 AM, David Miller wrote:
>> Looks like the early SH2/3 SoCs didn't implement the whole register.
>> Despite that, sh_eth_dev_init() always writes to this register... :-/
>> So far, the RMCR.RNC bit was mostly set for the Gigabit-capable
>> controllers, however that rule wasn't strictly followed. Well, this
>> driver is still a mess, and it's hard to deal with it without the
>> necessary documentation.
> Why don't we therefore:
> 1) Skip the register write if the per-chip value is zero.
I rather thought about not writing when the register is not implemented.
I'll probably look into this when I have time.
> 2) Add the RNC bit to all of the gigabit capable controllers.
I probably misspoke -- all the Gigabit controllers already have it set,
it's just that some 100 MBbps ones have it set, but most don't.
WBR, Sergei
next prev parent reply other threads:[~2014-06-02 20:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:17 [PATCH v2] sh_eth: use RNC mode for R8A7790/R87791 Ben Dooks
2014-06-02 18:53 ` David Miller
2014-06-02 19:06 ` Ben Dooks
2014-06-02 19:33 ` Sergei Shtylyov
2014-06-02 20:49 ` David Miller
2014-06-02 20:55 ` Sergei Shtylyov [this message]
2014-06-02 21:05 ` David Miller
2014-06-02 21:17 ` Sergei Shtylyov
2014-06-02 22:26 ` Sergei Shtylyov
2014-06-03 11:19 ` Ben Dooks
2014-06-03 20:02 ` Sergei Shtylyov
2014-06-03 2:45 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CE4CA.4090301@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ben.dooks@codethink.co.uk \
--cc=cm-hiep@jinso.co.jp \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-kernel@codethink.co.uk \
--cc=magnus.damn@opensource.se \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).