From mboxrd@z Thu Jan  1 00:00:00 1970
From: zhangfei <zhangfei.gao@linaro.org>
Subject: Re: [PATCH v3 2/2] net: hisilicon: add hix5hd2 mac driver
Date: Tue, 03 Jun 2014 13:38:30 +0800
Message-ID: <538D5F56.1030106@linaro.org>
References: <1401440528-7804-1-git-send-email-zhangfei.gao@linaro.org>	<1401440528-7804-3-git-send-email-zhangfei.gao@linaro.org> <20140602.161131.783479189097234753.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: arnd@arndb.de, f.fainelli@gmail.com,
	sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com,
	David.Laight@ACULAB.COM, eric.dumazet@gmail.com,
	haifeng.yan@linaro.org, jchxue@gmail.com,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org
To: David Miller <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-yh0-f49.google.com ([209.85.213.49]:48723 "EHLO
	mail-yh0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751318AbaFCFij (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 3 Jun 2014 01:38:39 -0400
Received: by mail-yh0-f49.google.com with SMTP id c41so4704938yho.36
        for <netdev@vger.kernel.org>; Mon, 02 Jun 2014 22:38:38 -0700 (PDT)
In-Reply-To: <20140602.161131.783479189097234753.davem@davemloft.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 06/03/2014 07:11 AM, David Miller wrote:
> From: Zhangfei Gao <zhangfei.gao@linaro.org>
> Date: Fri, 30 May 2014 17:02:08 +0800
>
>> +			skb = netdev_alloc_skb_ip_align(priv->netdev,
>> +				MAC_MAX_FRAME_SIZE);
>
> When a function call, declaration, or definition spans multiple lines,
> you must start the arguments on the second and subsequent lines exactly
> at the first column after the openning parenthesis.
>
> Please therefore reindent this properly.
Got it, not know this rule, will update accordingly.

>> +static int hix5hd2_mdio_wait_ready(struct mii_bus *bus)
>> +{
>> +	struct hix5hd2_priv *priv = bus->priv;
>> +	void __iomem *base = priv->base;
>> +	int i, timeout = 10000;
>> +
>> +	for (i = 0; readl_relaxed(base + MDIO_SINGLE_CMD) & MDIO_START; i++) {
>> +		if (i == timeout)
>> +			return -ETIMEDOUT;
>> +		udelay(1);
>> +	}
>> +
>> +	return 0;
>> +}
>
> 10,000 udelay(1)'s is a long time, consider changing to usleep() or
> similar.
>
Will use usleep_range(10, 20) instead.

Thanks