From: Michal Privoznik <mprivozn@redhat.com>
To: David Miller <davem@davemloft.net>, vfalico@redhat.com
Cc: jiri@resnulli.us, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net-sysfs: Report link speed as signed integer
Date: Tue, 03 Jun 2014 14:05:08 +0200 [thread overview]
Message-ID: <538DB9F4.9050201@redhat.com> (raw)
In-Reply-To: <538D7430.2080200@redhat.com>
On 03.06.2014 09:07, Michal Privoznik wrote:
> On 02.06.2014 20:10, David Miller wrote:
>> From: Veaceslav Falico <vfalico@redhat.com>
>> Date: Mon, 2 Jun 2014 17:01:50 +0200
>>
>>> I wonder, though, if we should document it or just output "Unknown"
>>> instead of -1.
>>
>> All of this discussion means that we can't change the format string
>> without potentially breaking something out there interpreting the -1
>> value, however it gets output now.
>
One more thing. The commit that changed the behavior is 8ae6daca which
is part of the 3.0 release. So any 2.6.X kernel does report -1 while
with 3.Y kernel you'll get this meaningless value. Having said that, we
already broke the applications so how about unbreaking them?
Michal
prev parent reply other threads:[~2014-06-03 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 14:25 [PATCH] net-sysfs: Report link speed as signed integer Michal Privoznik
2014-06-02 14:35 ` Jiri Pirko
2014-06-02 14:40 ` Bjørn Mork
2014-06-02 14:43 ` Michal Privoznik
2014-06-02 15:01 ` Veaceslav Falico
2014-06-02 17:21 ` Florian Fainelli
2014-06-02 18:10 ` David Miller
2014-06-03 7:07 ` Michal Privoznik
2014-06-03 12:05 ` Michal Privoznik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538DB9F4.9050201@redhat.com \
--to=mprivozn@redhat.com \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).