From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Privoznik Subject: Re: [PATCH] net-sysfs: Report link speed as signed integer Date: Tue, 03 Jun 2014 14:05:08 +0200 Message-ID: <538DB9F4.9050201@redhat.com> References: <06d53256e3bf2d0deedb16249082200500da3ee6.1401718809.git.mprivozn@redhat.com> <20140602143557.GA2925@minipsycho.orion> <20140602150150.GF6295@redhat.com> <20140602.111050.54996809312556969.davem@davemloft.net> <538D7430.2080200@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: David Miller , vfalico@redhat.com Return-path: In-Reply-To: <538D7430.2080200@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 03.06.2014 09:07, Michal Privoznik wrote: > On 02.06.2014 20:10, David Miller wrote: >> From: Veaceslav Falico >> Date: Mon, 2 Jun 2014 17:01:50 +0200 >> >>> I wonder, though, if we should document it or just output "Unknown" >>> instead of -1. >> >> All of this discussion means that we can't change the format string >> without potentially breaking something out there interpreting the -1 >> value, however it gets output now. > One more thing. The commit that changed the behavior is 8ae6daca which is part of the 3.0 release. So any 2.6.X kernel does report -1 while with 3.Y kernel you'll get this meaningless value. Having said that, we already broke the applications so how about unbreaking them? Michal