From: Florian Fainelli <f.fainelli@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: festevam@gmail.com, claudiu.manoil@freescale.com,
netdev@vger.kernel.org, fabio.estevam@freescale.com
Subject: Re: [PATCH] gianfar: Call netif_carrier_off() prior to registration
Date: Tue, 03 Jun 2014 19:42:04 -0700 [thread overview]
Message-ID: <538E877C.7080509@gmail.com> (raw)
In-Reply-To: <20140603.190526.241247147331404487.davem@davemloft.net>
Le 03/06/2014 19:05, David Miller a écrit :
> From: Florian Fainelli <f.fainelli@gmail.com>
> Date: Tue, 3 Jun 2014 16:04:49 -0700
>
>> 2014-06-03 15:55 GMT-07:00 Fabio Estevam <festevam@gmail.com>:
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> Quoting David Miller:
>>> "At the moment you call register_netdev() the device is visible, notifications
>>> are sent to userspace, and userland tools can try to bring the interface up
>>> and see the incorrect link state, before you do the netif_carrier_off().
>>>
>>> Said another way, between the register_netdev() and netif_carrier_off() call,
>>> userspace can see the device in an inconsistent state."
>>>
>>> So call netif_carrier_off() prior to register_netdev().
>>
>> Potentially all drivers implementing libphy correctly should be fixed
>> to start with a carrier off until the phy library has determined
>> otherwise.
>
> Are you saying we should hold off on this gianfar patch?
Not at all, I think this patch is fine. If Fabio wants/can audit the
other Freescale drivers I think this should be beneficial.
--
Florian
next prev parent reply other threads:[~2014-06-04 2:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 22:55 [PATCH] gianfar: Call netif_carrier_off() prior to registration Fabio Estevam
2014-06-03 23:04 ` Florian Fainelli
2014-06-04 2:05 ` David Miller
2014-06-04 2:42 ` Florian Fainelli [this message]
2014-06-04 2:51 ` Fabio Estevam
2014-06-05 22:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538E877C.7080509@gmail.com \
--to=f.fainelli@gmail.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).