From: David Vrabel <david.vrabel@citrix.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Wei Liu <wei.liu2@citrix.com>, <xen-devel@lists.xen.org>,
<netdev@vger.kernel.org>
Cc: paul.durrant@citrix.com,
"Andrew J. Bennieston" <andrew.bennieston@citrix.com>,
ian.campbell@citrix.com, zoltan.kiss@citrix.com,
a.j.bennieston@gmail.com
Subject: Re: [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif.
Date: Wed, 4 Jun 2014 15:52:52 +0100 [thread overview]
Message-ID: <538F32C4.8070409@citrix.com> (raw)
In-Reply-To: <538F3152.80501@cogentembedded.com>
On 04/06/14 15:46, Sergei Shtylyov wrote:
> Hello.
>
> On 06/04/2014 01:30 PM, Wei Liu wrote:
>
>> From: "Andrew J. Bennieston" <andrew.bennieston@citrix.com>
>
>> This array was allocated separately in commit ac3d5ac2 ("xen-netback:
>> fix guest-receive-side array sizes") due to it being very large, and a
>> struct xenvif is allocated as the netdev_priv part of a struct
>> net_device, i.e. via kmalloc() but falling back to vmalloc() if the
>> initial alloc. fails.
>
>> In preparation for the multi-queue patches, where this array becomes
>> part of struct xenvif_queue and is always allocated through vzalloc(),
>> move this back into the struct xenvif.
>
> Won't this cause an allocation failure and so break bisection at this
> patch?
No. As Andrew already said: "...falling back to vmalloc() if the
initial alloc. fails."
David
next prev parent reply other threads:[~2014-06-04 14:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 9:30 [PATCH net-next v10 0/7] Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 1/7] xen-netback: Move grant_copy_op array back into struct xenvif Wei Liu
2014-06-04 14:46 ` Sergei Shtylyov
2014-06-04 14:52 ` David Vrabel [this message]
2014-06-04 15:00 ` Sergei Shtylyov
2014-06-04 15:03 ` Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 2/7] xen-netback: Factor queue-specific data into queue struct Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 3/7] xen-netback: Add support for multiple queues Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 4/7] xen-netfront: Factor queue-specific data into queue struct Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 5/7] xen-netfront: Add support for multiple queues Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 6/7] xen-net{back,front}: Document multi-queue feature in netif.h Wei Liu
2014-06-04 9:30 ` [PATCH net-next v10 7/7] xen-netfront: initialise queue name in xennet_init_queue Wei Liu
2014-06-04 9:35 ` Andrew J. Bennieston
2014-06-04 21:49 ` [PATCH net-next v10 0/7] David Miller
2014-06-04 22:27 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F32C4.8070409@citrix.com \
--to=david.vrabel@citrix.com \
--cc=a.j.bennieston@gmail.com \
--cc=andrew.bennieston@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zoltan.kiss@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).