From: Zoltan Kiss <zoltan.kiss@citrix.com>
To: annie li <annie.li@oracle.com>
Cc: <xen-devel@lists.xenproject.org>, <ian.campbell@citrix.com>,
<wei.liu2@citrix.com>, <paul.durrant@citrix.com>,
<linux@eikelenboom.it>, <netdev@vger.kernel.org>,
<david.vrabel@citrix.com>, <davem@davemloft.net>
Subject: Re: [Xen-devel] [PATCH net] xen-netback: Fix handling of skbs requiring too many slots
Date: Wed, 4 Jun 2014 16:42:34 +0100 [thread overview]
Message-ID: <538F3E6A.7000002@citrix.com> (raw)
In-Reply-To: <538F369B.7010100@oracle.com>
On 04/06/14 16:09, annie li wrote:
>
> On 2014/6/3 16:30, Zoltan Kiss wrote:
>> A recent commit (a02eb4 "xen-netback: worse-case estimate in
>> xenvif_rx_action is
>> underestimating") capped the slot estimation to MAX_SKB_FRAGS, but
>> that triggers
>> the next BUG_ON a few lines down, as the packet consumes more slots than
>> estimated.
>> This patch introduces full_coalesce on the skb callback buffer, which
>> is used in
>> start_new_rx_buffer() to decide whether netback needs coalescing more
>> aggresively. By doing that, no packet should need more than
>> XEN_NETIF_MAX_TX_SIZE / PAGE_SIZE data slots,
>
> (XEN_NETIF_MAX_TX_SIZE+1) / PAGE_SIZE here?
Do you think about the GSO slot? That's why I wrote "data slot", however
that's probably not a clear terminology. I'll add then that excluding
GSO slot, as it doesn't carry data directly, therefore it's irrelevant
from this point of view.
Zoli
next prev parent reply other threads:[~2014-06-04 15:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 20:30 [PATCH net] xen-netback: Fix handling of skbs requiring too many slots Zoltan Kiss
2014-06-04 8:50 ` David Laight
2014-06-04 10:15 ` Zoltan Kiss
2014-06-04 15:53 ` Zoltan Kiss
2014-06-04 15:09 ` annie li
2014-06-04 15:42 ` Zoltan Kiss [this message]
2014-06-04 15:59 ` [Xen-devel] " annie li
2014-06-11 12:36 ` Zoltan Kiss
2014-06-11 19:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F3E6A.7000002@citrix.com \
--to=zoltan.kiss@citrix.com \
--cc=annie.li@oracle.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=linux@eikelenboom.it \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).