From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc Date: Fri, 06 Jun 2014 10:13:29 -0400 Message-ID: <5391CC89.1030104@gmail.com> References: <1401969212-19193-1-git-send-email-makita.toshiaki@lab.ntt.co.jp> <20140605.152151.1874961526019573838.davem@davemloft.net> <063D6719AE5E284EB5DD2968C1650D6D1725853E@AcuExch.aculab.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "stephen@networkplumber.org" , "vyasevic@redhat.com" , "bridge@lists.linux-foundation.org" , "netdev@vger.kernel.org" To: David Laight , 'David Miller' , "makita.toshiaki@lab.ntt.co.jp" Return-path: In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1725853E@AcuExch.aculab.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 06/06/2014 04:48 AM, David Laight wrote: > From: David Miller [mailto:davem@davemloft.net] >>> br_manage_promisc() incorrectly expects br_auto_port() to return only 0 >>> or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. >>> >>> Signed-off-by: Toshiaki Makita >> >> I'm applying this as-is for now, even though I saw the other >> suggestions in this thread (which BTW didn't get picked up by >> patchwork, maybe some of you dropped the Message-Id in your replies by >> accident). > > I don't have a problem with that. > The condition looks odd, but it is enabling promiscuous mode > if any other ports are in 'auto' mode. No, the condition is correct and explicit. The cases are: 0 auto ports == all ports are statically configured and non-promisc. 1 auto port == only this port can be non-promisc. all others promisc. > 1 auto port == all ports promisc. -vlad > Possibly the comment above made that clear, but it was truncated > in the diffs. > > David > > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >