From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [net-next 01/13] i40e: add checks for AQ error status bits Date: Mon, 09 Jun 2014 17:21:05 +0400 Message-ID: <5395B4C1.7070004@cogentembedded.com> References: <1402303758-1429-1-git-send-email-jeffrey.t.kirsher@intel.com> <1402303758-1429-2-git-send-email-jeffrey.t.kirsher@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff Kirsher , netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com To: davem@davemloft.net, Shannon Nelson Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:39465 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752679AbaFINVI (ORCPT ); Mon, 9 Jun 2014 09:21:08 -0400 Received: by mail-la0-f51.google.com with SMTP id gf5so3040014lab.38 for ; Mon, 09 Jun 2014 06:21:05 -0700 (PDT) In-Reply-To: <1402303758-1429-2-git-send-email-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello. On 06/09/2014 12:49 PM, Jeff Kirsher wrote: > From: Shannon Nelson > Check for error status bits on the AdminQ event queue and announce them > if seen. If the Firmware sets these bits, it will trigger an AdminQ > interrupt to get the driver's attention to process the ARQ, which will > likely be enough to clear the actual issue. > Signed-off-by: Shannon Nelson > Change-ID: I009e0ebc8be764e40e193b29aed2863f43eb5cb0 > Signed-off-by: Jeff Kirsher > --- > drivers/net/ethernet/intel/i40e/i40e_main.c | 36 +++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c > index 8c16e18..ab0b6e1 100644 > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c > @@ -5132,11 +5132,47 @@ static void i40e_clean_adminq_subtask(struct i40e_pf *pf) > u16 pending, i = 0; > i40e_status ret; > u16 opcode; > + u32 oldval; > u32 val; > > if (!test_bit(__I40E_ADMINQ_EVENT_PENDING, &pf->state)) > return; > > + /* check for error indications */ > + val = rd32(&pf->hw, pf->hw.aq.arq.len); > + oldval = val; > + if (val & I40E_PF_ARQLEN_ARQVFE_MASK) { > + dev_info(&pf->pdev->dev, "ARQ VF Error detected\n"); Hm, why not dev_err() here and below? > + val &= ~I40E_PF_ARQLEN_ARQVFE_MASK; > + } > + if (val & I40E_PF_ARQLEN_ARQOVFL_MASK) { > + dev_info(&pf->pdev->dev, "ARQ Overflow Error detected\n"); > + val &= ~I40E_PF_ARQLEN_ARQOVFL_MASK; > + } > + if (val & I40E_PF_ARQLEN_ARQCRIT_MASK) { > + dev_info(&pf->pdev->dev, "ARQ Critical Error detected\n"); > + val &= ~I40E_PF_ARQLEN_ARQCRIT_MASK; > + } > + if (oldval != val) > + wr32(&pf->hw, pf->hw.aq.arq.len, val); > + > + val = rd32(&pf->hw, pf->hw.aq.asq.len); > + oldval = val; > + if (val & I40E_PF_ATQLEN_ATQVFE_MASK) { > + dev_info(&pf->pdev->dev, "ASQ VF Error detected\n"); > + val &= ~I40E_PF_ATQLEN_ATQVFE_MASK; > + } > + if (val & I40E_PF_ATQLEN_ATQOVFL_MASK) { > + dev_info(&pf->pdev->dev, "ASQ Overflow Error detected\n"); > + val &= ~I40E_PF_ATQLEN_ATQOVFL_MASK; > + } > + if (val & I40E_PF_ATQLEN_ATQCRIT_MASK) { > + dev_info(&pf->pdev->dev, "ASQ Critical Error detected\n"); > + val &= ~I40E_PF_ATQLEN_ATQCRIT_MASK; > + } > + if (oldval != val) > + wr32(&pf->hw, pf->hw.aq.asq.len, val); > + WBR, Sergei