[PATCH] net/core: Add VF link state control policy

[PATCH] net/core: Add VF link state control policy

[Doug Ledford]

Commit 1d8faf48c7 added VF link state control to the netlink VF nested
structure, but failed to add a proper entry for the new structure into
the VF policy table.  Add the missing entry so the table and the actual
data copied into the netlink nested struct are in sync.

Signed-off-by: Doug Ledford <dledford@redhat.com>
---
 net/core/rtnetlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 2d8d8fcfa06..cdccf028171 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1208,6 +1208,8 @@ static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
 				    .len = sizeof(struct ifla_vf_tx_rate) },
 	[IFLA_VF_SPOOFCHK]	= { .type = NLA_BINARY,
 				    .len = sizeof(struct ifla_vf_spoofchk) },
+	[IFLA_VF_LINK_STATE]	= { .type = NLA_BINARY,
+				    .len = sizeof(struct ifla_vf_link_state) },
 };
 
 static const struct nla_policy ifla_port_policy[IFLA_PORT_MAX+1] = {
-- 
1.9.3

Re: [PATCH] net/core: Add VF link state control policy

[Sergei Shtylyov]

Hello.

On 06/10/2014 11:59 PM, Doug Ledford wrote:

> Commit 1d8faf48c7 added VF link state control to the netlink VF nested

    Please also specify that commit's summary line in parens.

> structure, but failed to add a proper entry for the new structure into
> the VF policy table.  Add the missing entry so the table and the actual
> data copied into the netlink nested struct are in sync.

> Signed-off-by: Doug Ledford <dledford@redhat.com>

WBR, Sergei

Re: [PATCH] net/core: Add VF link state control policy

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 753 bytes --]

On Wed, 2014-06-11 at 00:09 +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 06/10/2014 11:59 PM, Doug Ledford wrote:
> 
> > Commit 1d8faf48c7 added VF link state control to the netlink VF nested
> 
>     Please also specify that commit's summary line in parens.

It was almost a carbon copy of my own commit summary:

(net/core: Add VF link state control)

> 
> > structure, but failed to add a proper entry for the new structure into
> > the VF policy table.  Add the missing entry so the table and the actual
> > data copied into the netlink nested struct are in sync.
> 
> > Signed-off-by: Doug Ledford <dledford@redhat.com>
> 
> WBR, Sergei
> 


-- 
Doug Ledford <dledford@redhat.com>
              GPG KeyID: 0E572FDD



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] net/core: Add VF link state control policy

[David Miller]

From: Doug Ledford <dledford@redhat.com>
Date: Tue, 10 Jun 2014 16:12:08 -0400

> On Wed, 2014-06-11 at 00:09 +0400, Sergei Shtylyov wrote:
>> Hello.
>> 
>> On 06/10/2014 11:59 PM, Doug Ledford wrote:
>> 
>> > Commit 1d8faf48c7 added VF link state control to the netlink VF nested
>> 
>>     Please also specify that commit's summary line in parens.
> 
> It was almost a carbon copy of my own commit summary:
> 
> (net/core: Add VF link state control)

But that is the way we absolutely require commits to be referred to,
SHA IDs are ambiguous, especially when changes are backported into
other trees.  Given that, the only unambiguous thing left is the
precise text of the commit header line.

That's why I require it to be explicitly provided alongside commit's
referred to in commit messages.

Re: [PATCH] net/core: Add VF link state control policy

[Or Gerlitz]

On 10/06/2014 22:59, Doug Ledford wrote:
> Commit 1d8faf48c7 added VF link state control to the netlink VF nested
> structure, but failed to add a proper entry for the new structure into
> the VF policy table.  Add the missing entry so the table and the actual
> data copied into the netlink nested struct are in sync.
>
> Signed-off-by: Doug Ledford <dledford@redhat.com>
> ---
>   net/core/rtnetlink.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 2d8d8fcfa06..cdccf028171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1208,6 +1208,8 @@ static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
>   				    .len = sizeof(struct ifla_vf_tx_rate) },
>   	[IFLA_VF_SPOOFCHK]	= { .type = NLA_BINARY,
>   				    .len = sizeof(struct ifla_vf_spoofchk) },
> +	[IFLA_VF_LINK_STATE]	= { .type = NLA_BINARY,
> +				    .len = sizeof(struct ifla_vf_link_state) },
>   };

nice catch, thanks. Note that currently this table isn't in use, so 
fixing here would  actually serve to avoid future bugs, but this is of 
course OK too.

Rony and Or.

[PATCH] net/core: Add VF link state control policy

[Doug Ledford]

Commit 1d8faf48c7 (net/core: Add VF link state control) added VF link state
control to the netlink VF nested structure, but failed to add a proper entry
for the new structure into the VF policy table.  Add the missing entry so
the table and the actual data copied into the netlink nested struct are in
sync.

Signed-off-by: Doug Ledford <dledford@redhat.com>
---
 net/core/rtnetlink.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 2d8d8fcfa06..cdccf028171 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -1208,6 +1208,8 @@ static const struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = {
 				    .len = sizeof(struct ifla_vf_tx_rate) },
 	[IFLA_VF_SPOOFCHK]	= { .type = NLA_BINARY,
 				    .len = sizeof(struct ifla_vf_spoofchk) },
+	[IFLA_VF_LINK_STATE]	= { .type = NLA_BINARY,
+				    .len = sizeof(struct ifla_vf_link_state) },
 };
 
 static const struct nla_policy ifla_port_policy[IFLA_PORT_MAX+1] = {
-- 
1.9.3

Re: [PATCH] net/core: Add VF link state control policy

[David Miller]

From: Doug Ledford <dledford@redhat.com>
Date: Wed, 11 Jun 2014 10:38:03 -0400

> Commit 1d8faf48c7 (net/core: Add VF link state control) added VF link state
> control to the netlink VF nested structure, but failed to add a proper entry
> for the new structure into the VF policy table.  Add the missing entry so
> the table and the actual data copied into the netlink nested struct are in
> sync.
> 
> Signed-off-by: Doug Ledford <dledford@redhat.com>

Applied, thanks.