From: Tom Lendacky <thomas.lendacky@amd.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] amd-xgbe: unwind on error in xgbe_mdio_register()
Date: Wed, 11 Jun 2014 08:15:39 -0500 [thread overview]
Message-ID: <5398567B.2090607@amd.com> (raw)
In-Reply-To: <20140611065626.GC16443@mwanda>
On 06/11/2014 01:56 AM, Dan Carpenter wrote:
> There is a typo here so we return directly instead of unwinding.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> index 52bbdbf..ea7a5d6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-mdio.c
> @@ -367,7 +367,7 @@ int xgbe_mdio_register(struct xgbe_prv_data *pdata)
>
> if (!phydev->drv || (phydev->drv->phy_id == 0)) {
> netdev_err(netdev, "phy_id not valid\n");
> - return -ENODEV;
> + ret = -ENODEV;
> goto err_phy_connect;
> }
> DBGPR(" phy_connect_direct succeeded for PHY %s, link=%d\n",
>
next prev parent reply other threads:[~2014-06-11 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 6:56 [patch] amd-xgbe: unwind on error in xgbe_mdio_register() Dan Carpenter
2014-06-11 13:15 ` Tom Lendacky [this message]
2014-06-11 22:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5398567B.2090607@amd.com \
--to=thomas.lendacky@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).