Re: [patch net-next] openvswitch: introduce rtnl ops stub

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 12/06/2014 16:20, Jiri Pirko a écrit :
> This stub now allows userspace to see IFLA_INFO_KIND for ovs master and
> IFLA_INFO_SLAVE_KIND for slave.
>
> Note that I added ops->setup check into newlink and dellink in order to
> prevent creating and deleting openvswitch instances using rtnl for now.
>
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
net-next is closed ;-)

> ---
>   net/core/rtnetlink.c                 |  5 ++++-
>   net/openvswitch/datapath.c           |  9 ++++++++-
>   net/openvswitch/vport-internal_dev.c | 16 ++++++++++++++++
>   net/openvswitch/vport-internal_dev.h |  2 ++
>   4 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 233b5ae..b874139 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -1767,7 +1767,7 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh)
>   		return -ENODEV;
>
>   	ops = dev->rtnl_link_ops;
> -	if (!ops)
> +	if (!ops || !ops->setup)
>   		return -EOPNOTSUPP;
>
>   	ops->dellink(dev, &list_kill);
> @@ -2028,6 +2028,9 @@ replay:
>   			return -EOPNOTSUPP;
>   		}
>
> +		if (!ops->setup)
> +			return -EOPNOTSUPP;
> +
For this one, you could just add a ops->validate in openvswitch which returns
always -EOPNOTSUPP.