netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [request for stable inclusion] ipv6: reallocate addrconf router for ipv6 address when lo device up
@ 2014-06-16  2:04 Chen Weilong
  2014-06-16  2:29 ` David Miller
  0 siblings, 1 reply; 6+ messages in thread
From: Chen Weilong @ 2014-06-16  2:04 UTC (permalink / raw)
  To: gregkh, davem, gaofeng; +Cc: stable, netdev, hannes, sd, Chen Weilong, Li Zefan

From: Gao feng <gaofeng@cn.fujitsu.com>

commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5 upstream.

/* CHANGELOG */

CC: Sabrina Dubroca <sd@queasysnail.net>
CC: Hannes Frederic Sowa <hannes@stressinduktion.org>
Reported-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Weilong Chen <chenweilong@huawei.com>
Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
[weilong: s/ip6_rt_put/dst_release]
Signed-off-by: Chen Weilong <chenweilong@huawei.com>
Signed-off-by: Li Zefan <lizefan@huawei.com>
---
 net/ipv6/addrconf.c | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index abfa007..25399bf 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2435,8 +2435,18 @@ static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;
 
-			if (sp_ifa->rt)
-				continue;
+			if (sp_ifa->rt) {
+				/* This dst has been added to garbage list when
+				 * lo device down, release this obsolete dst and
+				 * reallocate a new router for ifa.
+				 */
+				if (sp_ifa->rt->dst.obsolete > 0) {
+					dst_release(sp_ifa->rt);
+					sp_ifa->rt = NULL;
+				} else {
+					continue;
+				}
+			}
 
 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
 
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [request for stable inclusion] ipv6: reallocate addrconf router for ipv6 address when lo device up
@ 2014-06-12  6:17 Chen Weilong
  0 siblings, 0 replies; 6+ messages in thread
From: Chen Weilong @ 2014-06-12  6:17 UTC (permalink / raw)
  To: davem, kuznet, jmorris, yoshfuji, kaber; +Cc: netdev, Weilong Chen

From: Weilong Chen <chenweilong@huawei.com>

"commit 33d99113b1102c2d2f8603b9ba72d89d915c13f5
ipv6: reallocate addrconf router for ipv6 address when lo device up."
This commit don't have a stable tag, but it fix the bug
no reply after loopback down-up.I think it should be
applied to stable 3.4.x kernels.

The bug is 67951 on bugzilla
https://bugzilla.kernel.org/show_bug.cgi?id=67951

The patch can't be applied directly. And it used the function introduced
by "commit 94e187c0" ip6_rt_put(), this patch can't be applied directly
either. 

Signed-off-by: Weilong Chen <chenweilong@huawei.com>
---
 include/net/ip6_fib.h |  9 +++++++++
 net/ipv6/addrconf.c   | 14 ++++++++++++--
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h
index 0ae759a..7c17c35 100644
--- a/include/net/ip6_fib.h
+++ b/include/net/ip6_fib.h
@@ -171,6 +171,15 @@ static inline void rt6_set_from(struct rt6_info *rt, struct rt6_info *from)
 	dst_hold(new);
 }
 
+static inline void ip6_rt_put(struct rt6_info *rt)
+{
+	/* dst_release() accepts a NULL parameter.
+	 * We rely on dst being first structure in struct rt6_info
+	 */
+	BUILD_BUG_ON(offsetof(struct rt6_info, dst) != 0);
+	dst_release(&rt->dst);
+}
+
 struct fib6_walker_t {
 	struct list_head lh;
 	struct fib6_node *root, *node;
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 9b8c3c6..00a0904 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2424,8 +2424,18 @@ static void init_loopback(struct net_device *dev)
 			if (sp_ifa->flags & (IFA_F_DADFAILED | IFA_F_TENTATIVE))
 				continue;
 
-			if (sp_ifa->rt)
-				continue;
+			if (sp_ifa->rt) {
+				/* This dst has been added to garbage list when
+				 * lo device down, release this obsolete dst and
+				 * reallocate a new router for ifa.
+				 */
+				if (sp_ifa->rt->dst.obsolete > 0) {
+					ip6_rt_put(sp_ifa->rt);
+					sp_ifa->rt = NULL;
+				} else {
+					continue;
+				}
+			}
 
 			sp_rt = addrconf_dst_alloc(idev, &sp_ifa->addr, 0);
 
-- 
1.7.12

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-17  3:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16  2:04 [request for stable inclusion] ipv6: reallocate addrconf router for ipv6 address when lo device up Chen Weilong
2014-06-16  2:29 ` David Miller
2014-06-16  3:14   ` chenweilong
2014-06-16 17:19     ` Cong Wang
2014-06-17  3:27       ` chenweilong
  -- strict thread matches above, loose matches on Subject: below --
2014-06-12  6:17 Chen Weilong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).