netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Casey Leedom <leedom@chelsio.com>
To: David Miller <davem@davemloft.net>, rongqing.li@windriver.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
	hariprasad@chelsio.com, greearb@candelatech.com
Subject: Re: [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock when read adap_rcu_list
Date: Mon, 23 Jun 2014 15:35:25 -0700	[thread overview]
Message-ID: <53A8ABAD.9090904@chelsio.com> (raw)
In-Reply-To: <20140623.145035.915335524137481573.davem@davemloft.net>


On 06/23/14 14:50, David Miller wrote:
> From: <rongqing.li@windriver.com>
> Date: Fri, 20 Jun 2014 17:32:36 +0800
>
>> cxgb4_netdev maybe lead to dead lock, since it uses a spin lock, and be called
>> in both thread and softirq context, but not disable BH, the lockdep report is
>> below; In fact, cxgb4_netdev only reads adap_rcu_list with RCU protection, so
>> not need to hold spin lock again.
> I think this change is fine, and correct, but I would like to see some
> reviews from the cxgb4 maintainers.

   Thanks David.  Hari is gone on PTO so I think I'm the next logical 
person ... :-)

   I've gone back and reviewed the original patch, Eric Dumazet6's reply 
and revised patch and compared that against this proposed patch.  Li 
RongQing is submitting the same patch that Eric suggested with the 
addition of a call to synchronize_rcu() the in driver remove() 
function.  I'm not super familiar with the RCU system but that addition 
certainly seems innocuous enough.  Other than that, everything looks fine.

  reply	other threads:[~2014-06-23 22:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  9:32 [PATCH][RFC] cxgb4: Not need to hold the adap_rcu_lock lock when read adap_rcu_list rongqing.li
2014-06-23 21:50 ` David Miller
2014-06-23 22:35   ` Casey Leedom [this message]
2014-06-24  0:20     ` Li RongQing
2014-06-24  6:38     ` Eric Dumazet
2014-06-24 16:42       ` Casey Leedom
2014-06-24 22:54 ` David Miller
2014-06-24 22:56   ` Casey Leedom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A8ABAD.9090904@chelsio.com \
    --to=leedom@chelsio.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=greearb@candelatech.com \
    --cc=hariprasad@chelsio.com \
    --cc=netdev@vger.kernel.org \
    --cc=rongqing.li@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).