From: Daniel Borkmann <dborkman@redhat.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexei Starovoitov <ast@plumgrid.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: filter: Use kcalloc/kmalloc_array to allocate arrays
Date: Tue, 24 Jun 2014 15:47:24 +0200 [thread overview]
Message-ID: <53A9816C.30903@redhat.com> (raw)
In-Reply-To: <1403616802-25743-3-git-send-email-tklauser@distanz.ch>
On 06/24/2014 03:33 PM, Tobias Klauser wrote:
> Use kcalloc/kmalloc_array to make it clear we're allocating arrays. No
> integer overflow can actually happen here, since len/flen is guaranteed
> to be less than BPF_MAXINSNS (4096). However, this changed makes sure
> we're not going to get one if BPF_MAXINSNS were ever increased.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
next prev parent reply other threads:[~2014-06-24 13:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 13:33 [PATCH] trivial: net: filter: Fix typo in comment Tobias Klauser
2014-06-24 13:33 ` [PATCH] trivial: net: filter: Change kerneldoc parameter order Tobias Klauser
2014-06-24 13:42 ` Daniel Borkmann
2014-06-24 15:02 ` Alexei Starovoitov
2014-06-25 23:39 ` David Miller
2014-06-24 13:33 ` [PATCH] net: filter: Use kcalloc/kmalloc_array to allocate arrays Tobias Klauser
2014-06-24 13:47 ` Daniel Borkmann [this message]
2014-06-24 15:03 ` Alexei Starovoitov
2014-06-25 23:40 ` David Miller
2014-06-24 13:41 ` [PATCH] trivial: net: filter: Fix typo in comment Daniel Borkmann
2014-06-24 15:01 ` Alexei Starovoitov
2014-06-25 23:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A9816C.30903@redhat.com \
--to=dborkman@redhat.com \
--cc=ast@plumgrid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).