From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markos Chandras Subject: Re: [PATCH 05/17] MIPS: bpf: Return error code if the offset is a negative number Date: Wed, 25 Jun 2014 09:12:53 +0100 Message-ID: <53AA8485.4040805@imgtec.com> References: <1403516340-22997-1-git-send-email-markos.chandras@imgtec.com> <1403516340-22997-6-git-send-email-markos.chandras@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Linux MIPS Mailing List , "David S. Miller" , Daniel Borkmann , "Network Development" To: Alexei Starovoitov Return-path: Received: from mailapp01.imgtec.com ([195.59.15.196]:28859 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755052AbaFYIM4 (ORCPT ); Wed, 25 Jun 2014 04:12:56 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 06/23/2014 11:09 PM, Alexei Starovoitov wrote: > On Mon, Jun 23, 2014 at 2:38 AM, Markos Chandras > wrote: >> Previously, the negative offset was not checked leading to failures >> due to trying to load data beyond the skb struct boundaries. Until we >> have proper asm helpers in place, it's best if we return ENOSUPP if K >> is negative when trying to JIT the filter or 0 during runtime if we >> do an indirect load where the value of X is unknown during build time. >> >> Cc: "David S. Miller" >> Cc: Daniel Borkmann >> Cc: Alexei Starovoitov >> Cc: netdev@vger.kernel.org >> Signed-off-by: Markos Chandras > > Hi Markos, > > thank you for addressing all of my earlier comments. > Looks like test_bpf was quite useful in finding all of these bugs :) > For the patches that reached netdev: > > Acked-by: Alexei Starovoitov > Thank you for the review and your constructive comments in your previous emails. -- markos