* [BUG] Circular dependency introduced in commit 86f6cf4127
@ 2014-06-25 15:44 Jeff Mahoney
2014-06-25 22:40 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Mahoney @ 2014-06-25 15:44 UTC (permalink / raw)
To: Daniel Mack, Florian Fainelli, David S. Miller, netdev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi guys -
Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
introduced a circular dependency between libphy and of_mdio.
depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
dependency cycle!
depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!
- -Jeff
- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.19 (Darwin)
iQIcBAEBAgAGBQJTqu5iAAoJEB57S2MheeWyPMwP/3tpviCx3A70xZMxdS1QA4uK
oyoTgTK+y0i6gTh4Mtkehzt6+lZAHyRso1OkUfo0oHflFDHQFbfHmN4ec1NIghpz
L3XdLaYx0U485ziFtmnbaWm24lhgOwyK33QTMZANJ0OiOSOqNY5+NG8uxH1XOrJj
eklbNo5Cya6Veqy1P4LovfrlNK1RflGcxdPOq2a7GVpJP7dP4wupoPIhIKCZD7O0
EL3Fo9bJ3+PNZT9pAaavBx6fjqqjLGOdj3QeBSkXxYvE5rueH0UNESZM+hytgQmo
dIItCY0b95aJsxf26OcjJoWJgVX81GTlrT+HBzTLD5uKqHvi0Zt/A6RduWeS3am3
2WxlXGaFshiqeRpm+0gz5OzZnWKaLLpxMmMKqrdFFSKoaPHdqcBcKbqp2yKqGXdk
sUN/qCA5S3JPpxwbKoZOAR03NIvq6b5wyK2/LKsU3HY9eMjmGh5m1vcFnWSZ21BM
lz70tqdoWchZ9FqffE2tKsDdtaL/HOFrcq5kcRnoy5L/F5HJ4TPh/t33bTN4D8Zw
lpTPe4LgtcN1dLlgDFVLDwAHDYWQ+BBOPUYjCVtXhFCzknl+uhB4OYZ8lsb/Wx8u
apBeq3M/+wGMQw5khVOW6wM7r6EklqJbs0Zbova8aUaxknbTK4weJXAnW6BCWzHZ
6AX74FFiHH+pt/xFK8fQ
=C7lH
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] Circular dependency introduced in commit 86f6cf4127
2014-06-25 15:44 [BUG] Circular dependency introduced in commit 86f6cf4127 Jeff Mahoney
@ 2014-06-25 22:40 ` David Miller
2014-06-26 7:11 ` Daniel Mack
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2014-06-25 22:40 UTC (permalink / raw)
To: jeffm; +Cc: zonque, f.fainelli, netdev
From: Jeff Mahoney <jeffm@suse.com>
Date: Wed, 25 Jun 2014 11:44:34 -0400
> Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
> introduced a circular dependency between libphy and of_mdio.
>
> depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
> dependency cycle!
> depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!
Yeah, of_mdio.c references &mdio_bus_type and libphy now references
of_mdiobus_link_phydev.
Daniel, please work on fixing this, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [BUG] Circular dependency introduced in commit 86f6cf4127
2014-06-25 22:40 ` David Miller
@ 2014-06-26 7:11 ` Daniel Mack
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2014-06-26 7:11 UTC (permalink / raw)
To: David Miller, jeffm; +Cc: f.fainelli, netdev
On 06/26/2014 12:40 AM, David Miller wrote:
> From: Jeff Mahoney <jeffm@suse.com>
> Date: Wed, 25 Jun 2014 11:44:34 -0400
>
>> Commit 86f6cf4127 (net: of_mdio: add of_mdiobus_link_phydev())
>> introduced a circular dependency between libphy and of_mdio.
>>
>> depmod: ERROR: <modroot>/kernel/drivers/net/phy/libphy.ko in
>> dependency cycle!
>> depmod: ERROR: <modroot>/kernel/drivers/of/of_mdio.ko in dependency cycle!
>
> Yeah, of_mdio.c references &mdio_bus_type and libphy now references
> of_mdiobus_link_phydev.
>
> Daniel, please work on fixing this, thanks.
>
Patch sent. Apologies for the breakage!
Daniel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-26 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 15:44 [BUG] Circular dependency introduced in commit 86f6cf4127 Jeff Mahoney
2014-06-25 22:40 ` David Miller
2014-06-26 7:11 ` Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).