* [PATCH v2] udp: Add MIB counters for rcvbuferrors
2014-06-21 22:07 [PATCH] " David Miller
@ 2014-06-25 21:30 ` James M Leddy
2014-06-27 4:22 ` Eric Dumazet
0 siblings, 1 reply; 7+ messages in thread
From: James M Leddy @ 2014-06-25 21:30 UTC (permalink / raw)
To: netdev; +Cc: James M Leddy
Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
Signed-off-by: James M Leddy <james.leddy@redhat.com>
---
net/ipv4/udp.c | 5 ++++-
net/ipv6/udp.c | 6 +++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index d92f94b..7d5a866 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1588,8 +1588,11 @@ int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP_INC_STATS_BH(sock_net(sk), UDP_MIB_RCVBUFERRORS,
+ is_udplite);
goto drop;
+ }
rc = 0;
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 95c8347..7092ff7 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -674,8 +674,11 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
}
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP6_INC_STATS_BH(sock_net(sk),
+ UDP_MIB_RCVBUFERRORS, is_udplite);
goto drop;
+ }
skb_dst_drop(skb);
@@ -690,6 +693,7 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
bh_unlock_sock(sk);
return rc;
+
csum_error:
UDP6_INC_STATS_BH(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite);
drop:
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] udp: Add MIB counters for rcvbuferrors
@ 2014-06-25 21:33 James M Leddy
0 siblings, 0 replies; 7+ messages in thread
From: James M Leddy @ 2014-06-25 21:33 UTC (permalink / raw)
To: netdev; +Cc: James M Leddy
Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
Signed-off-by: James M Leddy <james.leddy@redhat.com>
---
net/ipv4/udp.c | 5 ++++-
net/ipv6/udp.c | 6 +++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index d92f94b..7d5a866 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1588,8 +1588,11 @@ int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP_INC_STATS_BH(sock_net(sk), UDP_MIB_RCVBUFERRORS,
+ is_udplite);
goto drop;
+ }
rc = 0;
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 95c8347..7092ff7 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -674,8 +674,11 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
}
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP6_INC_STATS_BH(sock_net(sk),
+ UDP_MIB_RCVBUFERRORS, is_udplite);
goto drop;
+ }
skb_dst_drop(skb);
@@ -690,6 +693,7 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
bh_unlock_sock(sk);
return rc;
+
csum_error:
UDP6_INC_STATS_BH(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite);
drop:
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2] udp: Add MIB counters for rcvbuferrors
@ 2014-06-25 21:38 James M Leddy
2014-06-26 1:11 ` James M Leddy
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: James M Leddy @ 2014-06-25 21:38 UTC (permalink / raw)
To: netdev; +Cc: James M Leddy
Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
Signed-off-by: James M Leddy <james.leddy@redhat.com>
---
net/ipv4/udp.c | 5 ++++-
net/ipv6/udp.c | 6 +++++-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index d92f94b..7d5a866 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1588,8 +1588,11 @@ int udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP_INC_STATS_BH(sock_net(sk), UDP_MIB_RCVBUFERRORS,
+ is_udplite);
goto drop;
+ }
rc = 0;
diff --git a/net/ipv6/udp.c b/net/ipv6/udp.c
index 95c8347..7092ff7 100644
--- a/net/ipv6/udp.c
+++ b/net/ipv6/udp.c
@@ -674,8 +674,11 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
goto csum_error;
}
- if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf))
+ if (sk_rcvqueues_full(sk, skb, sk->sk_rcvbuf)) {
+ UDP6_INC_STATS_BH(sock_net(sk),
+ UDP_MIB_RCVBUFERRORS, is_udplite);
goto drop;
+ }
skb_dst_drop(skb);
@@ -690,6 +693,7 @@ int udpv6_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
bh_unlock_sock(sk);
return rc;
+
csum_error:
UDP6_INC_STATS_BH(sock_net(sk), UDP_MIB_CSUMERRORS, is_udplite);
drop:
--
1.7.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] udp: Add MIB counters for rcvbuferrors
2014-06-25 21:38 [PATCH v2] udp: Add MIB counters for rcvbuferrors James M Leddy
@ 2014-06-26 1:11 ` James M Leddy
2014-06-27 4:29 ` Eric Dumazet
2014-06-27 7:21 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: James M Leddy @ 2014-06-26 1:11 UTC (permalink / raw)
To: netdev
whoops, sorry for the noise
--
James M Leddy
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] udp: Add MIB counters for rcvbuferrors
2014-06-25 21:30 ` [PATCH v2] " James M Leddy
@ 2014-06-27 4:22 ` Eric Dumazet
0 siblings, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2014-06-27 4:22 UTC (permalink / raw)
To: James M Leddy; +Cc: netdev
On Wed, 2014-06-25 at 17:30 -0400, James M Leddy wrote:
> Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
>
> Signed-off-by: James M Leddy <james.leddy@redhat.com>
> ---
> net/ipv4/udp.c | 5 ++++-
> net/ipv6/udp.c | 6 +++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] udp: Add MIB counters for rcvbuferrors
2014-06-25 21:38 [PATCH v2] udp: Add MIB counters for rcvbuferrors James M Leddy
2014-06-26 1:11 ` James M Leddy
@ 2014-06-27 4:29 ` Eric Dumazet
2014-06-27 7:21 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: Eric Dumazet @ 2014-06-27 4:29 UTC (permalink / raw)
To: James M Leddy; +Cc: netdev
On Wed, 2014-06-25 at 17:38 -0400, James M Leddy wrote:
> Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
>
> Signed-off-by: James M Leddy <james.leddy@redhat.com>
> ---
> net/ipv4/udp.c | 5 ++++-
> net/ipv6/udp.c | 6 +++++-
> 2 files changed, 9 insertions(+), 2 deletions(-)
Acked-by: Eric Dumazet <edumazet@google.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] udp: Add MIB counters for rcvbuferrors
2014-06-25 21:38 [PATCH v2] udp: Add MIB counters for rcvbuferrors James M Leddy
2014-06-26 1:11 ` James M Leddy
2014-06-27 4:29 ` Eric Dumazet
@ 2014-06-27 7:21 ` David Miller
2 siblings, 0 replies; 7+ messages in thread
From: David Miller @ 2014-06-27 7:21 UTC (permalink / raw)
To: james.leddy; +Cc: netdev
From: James M Leddy <james.leddy@redhat.com>
Date: Wed, 25 Jun 2014 17:38:13 -0400
> Add MIB counters for rcvbuferrors in UDP to help diagnose problems.
>
> Signed-off-by: James M Leddy <james.leddy@redhat.com>
Applied, thanks James.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-06-27 7:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-25 21:38 [PATCH v2] udp: Add MIB counters for rcvbuferrors James M Leddy
2014-06-26 1:11 ` James M Leddy
2014-06-27 4:29 ` Eric Dumazet
2014-06-27 7:21 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-06-25 21:33 James M Leddy
2014-06-21 22:07 [PATCH] " David Miller
2014-06-25 21:30 ` [PATCH v2] " James M Leddy
2014-06-27 4:22 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).