From: Amir Vadai <amirv@mellanox.com>
To: David Miller <davem@davemloft.net>, <amirv.mellanox@gmail.com>
Cc: <eric.dumazet@gmail.com>, <netdev@vger.kernel.org>,
<ogerlitz@mellanox.com>, <yevgenyp@mellanox.com>,
<tglx@linutronix.de>, <ben@decadent.org.uk>, <amira@mellanox.com>,
<yuvala@mellanox.com>
Subject: Re: [PATCH net V1 1/3] net/mlx4_en: Don't use irq_affinity_notifier to track changes in IRQ affinity map
Date: Tue, 1 Jul 2014 12:14:29 +0300 [thread overview]
Message-ID: <53B27BF5.6080608@mellanox.com> (raw)
In-Reply-To: <20140630.203308.1311350484055713992.davem@davemloft.net>
On 07/01/2014 06:33 AM, David Miller wrote:
> From: Amir Vadai <amirv.mellanox@gmail.com>
> Date: Mon, 30 Jun 2014 11:34:22 +0300
>
>> On 6/30/2014 9:41 AM, Eric Dumazet wrote:
>>> You might want to drain whole queue instead of limiting to a 'budget',
>>> otherwise, a cpu might be stuck servicing (soft)irq for the TX
>>> completion, even if irq affinities say otherwise.
>>>
>>
>> TX completions are very quick compared to the skb preparation and
>> sending. Which is not the case for RX completions. Because of that, it
>> is very easy to reproduce the problem in RX flows, but we never had any
>> report of that problem in the TX flow.
>> I prefer not to spend time on the TX, since we plan to send a patch soon
>> to use the same NAPI for both TX and RX.
>
> It is always advised to completely ignore the budget for TX work, this is
> what we tell every driver author when discussion NAPI implementations.
>
> Please make your driver conform to this, thanks.
>
Ok.
Please continue the process on this V1 of the patchset. The fix to TX
poll is not related to this patch - this patch is fixing a regression
that broke aRFS in mlx4_en.
I will send a separate fix to purge all packets on TX work later on this
week.
Thanks,
Amir
next prev parent reply other threads:[~2014-07-01 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-29 8:54 [PATCH net V1 0/3] Mellanox EN driver fixes 2014-06-23 Amir Vadai
2014-06-29 8:54 ` [PATCH net V1 1/3] net/mlx4_en: Don't use irq_affinity_notifier to track changes in IRQ affinity map Amir Vadai
2014-06-30 6:41 ` Eric Dumazet
2014-06-30 8:34 ` Amir Vadai
2014-06-30 9:11 ` Eric Dumazet
2014-06-30 10:43 ` Amir Vadai
2014-07-01 3:33 ` David Miller
2014-07-01 9:14 ` Amir Vadai [this message]
2014-06-29 8:54 ` [PATCH net V1 2/3] lib/cpumask: cpumask_set_cpu_local_first to use all cores when numa node is not defined Amir Vadai
2014-06-29 8:54 ` [PATCH net V1 3/3] net/mlx4_en: IRQ affinity hint is not cleared on port down Amir Vadai
2014-07-03 1:29 ` [PATCH net V1 0/3] Mellanox EN driver fixes 2014-06-23 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B27BF5.6080608@mellanox.com \
--to=amirv@mellanox.com \
--cc=amira@mellanox.com \
--cc=amirv.mellanox@gmail.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=tglx@linutronix.de \
--cc=yevgenyp@mellanox.com \
--cc=yuvala@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).