From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 2/3] ARM: mvebu: Add support for the network controller
 in Armada 375 SoC
Date: Fri, 04 Jul 2014 22:51:02 +0400
Message-ID: <53B6F796.3090004@cogentembedded.com>
References: <1404498697-21978-1-git-send-email-ezequiel.garcia@free-electrons.com> <1404498697-21978-3-git-send-email-ezequiel.garcia@free-electrons.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
	Jason Cooper <jason@lakedaemon.net>,
	Marcin Wojtas <mw@semihalf.com>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Tawfik Bayouk <tawfik@marvell.com>,
	Lior Amsalem <alior@marvell.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-la0-f44.google.com ([209.85.215.44]:36729 "EHLO
	mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753279AbaGDSuz (ORCPT
	<rfc822;netdev@vger.kernel.org>); Fri, 4 Jul 2014 14:50:55 -0400
Received: by mail-la0-f44.google.com with SMTP id ty20so1403134lab.31
        for <netdev@vger.kernel.org>; Fri, 04 Jul 2014 11:50:53 -0700 (PDT)
In-Reply-To: <1404498697-21978-3-git-send-email-ezequiel.garcia@free-electrons.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hello.

On 07/04/2014 10:31 PM, Ezequiel Garcia wrote:

> This commit adds the support for the network controller in Marvell
> Armada 375 SoC devicetree.

> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> ---
>   arch/arm/boot/dts/armada-375.dtsi | 31 +++++++++++++++++++++++++++++++
>   1 file changed, 31 insertions(+)

> diff --git a/arch/arm/boot/dts/armada-375.dtsi b/arch/arm/boot/dts/armada-375.dtsi
> index fb92551..5e897d2 100644
> --- a/arch/arm/boot/dts/armada-375.dtsi
> +++ b/arch/arm/boot/dts/armada-375.dtsi
> @@ -151,6 +151,37 @@
>   				      <0xc100 0x100>;
>   			};
>
> +			mdio {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "marvell,orion-mdio";
> +				reg = <0xc0054 0x4>;
> +			};
> +
> +			/* Network controller */
> +			pp2@f0000 {
> +				compatible = "marvell,armada-375-pp2";
> +				reg = <0xf0000 0xa000>, /* Packet Processor regs */
> +				      <0xc0000 0x3060>, /* LMS regs */
> +				      <0xc4000 0x100>,  /* eth0 regs */
> +				      <0xc5000 0x100>;  /* eth1 regs */

    Hm, why are the above two ranges not listed under the "ethernet" subnodes?

> +				clocks = <&gateclk 3>, <&gateclk 19>;
> +				clock-names = "pp_clk", "gop_clk";
> +				status = "disabled";
> +
> +				eth0: ethernet@c4000 {
> +					interrupts = <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>;
> +					port-id = <0>;
> +					status = "disabled";
> +				};
> +
> +				eth1: ethernet@c5000 {
> +					interrupts = <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>;
> +					port-id = <1>;
> +					status = "disabled";
> +				};
> +			};
> +

WBR, Sergei