From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH] hyperv: Add netpoll support Date: Wed, 09 Jul 2014 00:53:26 +0200 Message-ID: <53BC7666.3050408@nod.at> References: <1404811947-5174-1-git-send-email-richard@nod.at> <9fb91c2ee32a4a59a2bec54043a6b9fd@BY2PR03MB299.namprd03.prod.outlook.com> <53BC3AC5.6000203@nod.at> <53BC51B4.4010703@nod.at> <20140708224724.GA2994@electric-eye.fr.zoreil.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "devel@linuxdriverproject.org" , Haiyang Zhang , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" To: Francois Romieu Return-path: In-Reply-To: <20140708224724.GA2994@electric-eye.fr.zoreil.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: driverdev-devel-bounces@linuxdriverproject.org List-Id: netdev.vger.kernel.org Am 09.07.2014 00:47, schrieb Francois Romieu: > Richard Weinberger : > [...] >> This won't work as netpoll runs with IRQs disabled. >> ->ndo_poll_controller() has to make sure that SKBs can be received and transmitted >> while IRQs are off. I thought calling the channel callback by hand would be >> enough to receive SKBs. > > What are you taking about ? netconsole does not need to receive. Isn't netconsole is only one user of netpoll? Of course netconsole needs only to transmit SKBs. But if you look at other ->ndo_poll_controller implementations you'll notice that they care also about receiving. > hyperv start_xmit handler almost does its own Tx completion as you have > noticed. The situation is imho close to a virtual device one as was veth > in bb446c19fefd7b4435adb12a9dd7666adc5b553a. Bad commit reference: bb446c19fefd7b4435adb12a9dd7666adc5b553a :-( Thanks, //richard