From: Richard Weinberger <richard@nod.at>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] hyperv: Add netpoll support
Date: Wed, 09 Jul 2014 01:08:35 +0200 [thread overview]
Message-ID: <53BC79F3.8080409@nod.at> (raw)
In-Reply-To: <20140708224724.GA2994@electric-eye.fr.zoreil.com>
Am 09.07.2014 00:47, schrieb Francois Romieu:
> Richard Weinberger <richard@nod.at> :
> [...]
>> This won't work as netpoll runs with IRQs disabled.
>> ->ndo_poll_controller() has to make sure that SKBs can be received and transmitted
>> while IRQs are off. I thought calling the channel callback by hand would be
>> enough to receive SKBs.
>
> What are you taking about ? netconsole does not need to receive.
>
> hyperv start_xmit handler almost does its own Tx completion as you have
> noticed. The situation is imho close to a virtual device one as was veth
> in bb446c19fefd7b4435adb12a9dd7666adc5b553a.
Ah, net-next.git.
My first (in-house) patch had the same empty poll controller as tun.c and now veth.c have.
If we are fine with tx only, I'll happily resend an updated patch with an empty poll controller. :-)
Thanks,
//richard
prev parent reply other threads:[~2014-07-08 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 9:32 [PATCH] hyperv: Add netpoll support Richard Weinberger
2014-07-08 17:55 ` Haiyang Zhang
2014-07-08 18:40 ` Richard Weinberger
2014-07-08 18:51 ` Haiyang Zhang
2014-07-08 18:01 ` KY Srinivasan
2014-07-08 18:39 ` Richard Weinberger
2014-07-08 20:03 ` KY Srinivasan
2014-07-08 20:16 ` Richard Weinberger
2014-07-08 22:47 ` Francois Romieu
2014-07-08 22:53 ` Richard Weinberger
2014-07-08 23:43 ` Francois Romieu
2014-07-09 7:59 ` Richard Weinberger
2014-07-08 23:08 ` Richard Weinberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BC79F3.8080409@nod.at \
--to=richard@nod.at \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).