From: Varka Bhadram <varkabhadram@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, alex.aring@gmail.com,
linux-zigbee-devel@lists.sourceforge.net, varkab@cdac.in
Subject: Re: [PATCH net-next 1/2] ieee802154: removed unwanted header files
Date: Wed, 09 Jul 2014 09:57:08 +0530 [thread overview]
Message-ID: <53BCC49C.5090503@gmail.com> (raw)
In-Reply-To: <20140708.205605.1846044536261079477.davem@davemloft.net>
On 07/09/2014 09:26 AM, David Miller wrote:
> These changes are completely bogus.
>
> Where are the definitions of the data types for "struct in6_addr" and
> "struct ipv6hdr" coming from.
>
> I'm not even going to look at these patches until you:
>
> 1) Properly audit the files. Removing an include and typing "make"
> is not auditing the header file requriements. Reading the code
> and looking at where declarations and definitions actually come
> from _is_.
I got your point. Thanks
>
> 2) Write a real commit message, this one is way too terse and tells me
> nothing. Explain why each header file was removed, and what the
> justification is.
Ok i will explain about the changes. I thinks i have to change the entire
patch. I have to rework on it. Thanks
--
Regards,
Varka Bhadram.
next prev parent reply other threads:[~2014-07-09 4:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 3:44 [PATCH net-next 0/2] cleanup for ieee802154 and mac802154 Varka Bhadram
2014-07-09 3:44 ` [PATCH net-next 1/2] ieee802154: removed unwanted header files Varka Bhadram
2014-07-09 3:56 ` David Miller
2014-07-09 4:27 ` Varka Bhadram [this message]
2014-07-09 3:44 ` [PATCH net-next 2/2] mac802154: " Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BCC49C.5090503@gmail.com \
--to=varkabhadram@gmail.com \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=varkab@cdac.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).