From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Richard Weinberger <richard@nod.at>,
kys@microsoft.com, haiyangz@microsoft.com
Cc: romieu@fr.zoreil.com, devel@linuxdriverproject.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hyperv: Add netpoll support
Date: Wed, 09 Jul 2014 18:13:17 +0400 [thread overview]
Message-ID: <53BD4DFD.6070805@cogentembedded.com> (raw)
In-Reply-To: <1404892702-11094-1-git-send-email-richard@nod.at>
Hello.
On 07/09/2014 11:58 AM, Richard Weinberger wrote:
> In order to have at least a netconsole to debug kernel issues on
> Windows Azure this patch implements netpoll support.
> Sending packets is easy, netvsc_start_xmit() does already everything
> needed.
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4fd71b7..45218d5 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
> return err;
> }
>
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void netvsc_poll_controller(struct net_device *net)
> +{
> + /* As netvsc_start_xmit() works synchronous we don't have to
> + trigger anything here. */
The multi-line comment style in the networking code is this:
/* bla
* bla
*/
> + return;
Not needed.
> +}
> +#endif
[...]
WBR, Sergei
next prev parent reply other threads:[~2014-07-09 14:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 7:58 [PATCH v2] hyperv: Add netpoll support Richard Weinberger
2014-07-09 14:13 ` Sergei Shtylyov [this message]
2014-07-09 14:24 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BD4DFD.6070805@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devel@linuxdriverproject.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richard@nod.at \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).