* [PATCH v2] hyperv: Add netpoll support
@ 2014-07-09 7:58 Richard Weinberger
2014-07-09 14:13 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2014-07-09 7:58 UTC (permalink / raw)
To: kys, haiyangz; +Cc: Richard Weinberger, devel, netdev, linux-kernel, romieu
In order to have at least a netconsole to debug kernel issues on
Windows Azure this patch implements netpoll support.
Sending packets is easy, netvsc_start_xmit() does already everything
needed.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index 4fd71b7..45218d5 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
return err;
}
+#ifdef CONFIG_NET_POLL_CONTROLLER
+static void netvsc_poll_controller(struct net_device *net)
+{
+ /* As netvsc_start_xmit() works synchronous we don't have to
+ trigger anything here. */
+ return;
+}
+#endif
static const struct ethtool_ops ethtool_ops = {
.get_drvinfo = netvsc_get_drvinfo,
@@ -751,6 +759,9 @@ static const struct net_device_ops device_ops = {
.ndo_validate_addr = eth_validate_addr,
.ndo_set_mac_address = netvsc_set_mac_addr,
.ndo_select_queue = netvsc_select_queue,
+#ifdef CONFIG_NET_POLL_CONTROLLER
+ .ndo_poll_controller = netvsc_poll_controller,
+#endif
};
/*
--
2.0.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hyperv: Add netpoll support
2014-07-09 7:58 [PATCH v2] hyperv: Add netpoll support Richard Weinberger
@ 2014-07-09 14:13 ` Sergei Shtylyov
2014-07-09 14:24 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2014-07-09 14:13 UTC (permalink / raw)
To: Richard Weinberger, kys, haiyangz; +Cc: romieu, devel, netdev, linux-kernel
Hello.
On 07/09/2014 11:58 AM, Richard Weinberger wrote:
> In order to have at least a netconsole to debug kernel issues on
> Windows Azure this patch implements netpoll support.
> Sending packets is easy, netvsc_start_xmit() does already everything
> needed.
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index 4fd71b7..45218d5 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
> return err;
> }
>
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> +static void netvsc_poll_controller(struct net_device *net)
> +{
> + /* As netvsc_start_xmit() works synchronous we don't have to
> + trigger anything here. */
The multi-line comment style in the networking code is this:
/* bla
* bla
*/
> + return;
Not needed.
> +}
> +#endif
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] hyperv: Add netpoll support
2014-07-09 14:13 ` Sergei Shtylyov
@ 2014-07-09 14:24 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2014-07-09 14:24 UTC (permalink / raw)
To: Sergei Shtylyov, kys, haiyangz; +Cc: devel, netdev, linux-kernel, romieu
Am 09.07.2014 16:13, schrieb Sergei Shtylyov:
> Hello.
>
> On 07/09/2014 11:58 AM, Richard Weinberger wrote:
>
>> In order to have at least a netconsole to debug kernel issues on
>> Windows Azure this patch implements netpoll support.
>> Sending packets is easy, netvsc_start_xmit() does already everything
>> needed.
>
>> Signed-off-by: Richard Weinberger <richard@nod.at>
>> ---
>> drivers/net/hyperv/netvsc_drv.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>
>> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
>> index 4fd71b7..45218d5 100644
>> --- a/drivers/net/hyperv/netvsc_drv.c
>> +++ b/drivers/net/hyperv/netvsc_drv.c
>> @@ -736,6 +736,14 @@ static int netvsc_set_mac_addr(struct net_device *ndev, void *p)
>> return err;
>> }
>>
>> +#ifdef CONFIG_NET_POLL_CONTROLLER
>> +static void netvsc_poll_controller(struct net_device *net)
>> +{
>> + /* As netvsc_start_xmit() works synchronous we don't have to
>> + trigger anything here. */
>
> The multi-line comment style in the networking code is this:
>
> /* bla
> * bla
> */
>
>> + return;
>
> Not needed.
>
>> +}
>> +#endif
> [...]
-ETOOMANYCODINGSTYLES :)
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-07-09 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-09 7:58 [PATCH v2] hyperv: Add netpoll support Richard Weinberger
2014-07-09 14:13 ` Sergei Shtylyov
2014-07-09 14:24 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).