netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
To: roy.qing.li@gmail.com, netdev@vger.kernel.org
Cc: hideaki.yoshifuji@miraclelinux.com
Subject: Re: [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup
Date: Fri, 11 Jul 2014 15:45:42 +0900	[thread overview]
Message-ID: <53BF8816.8010400@miraclelinux.com> (raw)
In-Reply-To: <1405060451-12633-1-git-send-email-roy.qing.li@gmail.com>

Hi,

roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
> 
> it should be "anycast destination", not "anycast source"
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
>   net/ipv6/icmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
> index f6c84a6..481fd5a 100644
> --- a/net/ipv6/icmp.c
> +++ b/net/ipv6/icmp.c
> @@ -334,7 +334,7 @@ static struct dst_entry *icmpv6_route_lookup(struct net *net,
>   	 * anycast.
>   	 */
>   	if (((struct rt6_info *)dst)->rt6i_flags & RTF_ANYCAST) {
> -		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast source\n");
> +		LIMIT_NETDEBUG(KERN_DEBUG "icmp6_send: acast destination\n");
>   		dst_release(dst);
>   		return ERR_PTR(-EINVAL);
>   	}
> 

No.
It is used by icmp6_send() and it means icmp6_send() won't
send back to the original "anycast" source addresses.

--yoshfuji

  reply	other threads:[~2014-07-11  6:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11  6:34 [PATCH net-next] ipv6: fix the debug information in icmpv6_route_lookup roy.qing.li
2014-07-11  6:45 ` YOSHIFUJI Hideaki [this message]
2014-07-11  6:51   ` Li RongQing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53BF8816.8010400@miraclelinux.com \
    --to=hideaki.yoshifuji@miraclelinux.com \
    --cc=netdev@vger.kernel.org \
    --cc=roy.qing.li@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).