From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH v7 29/33] net: brcmfmac - set name assign type Date: Fri, 11 Jul 2014 09:45:34 +0200 Message-ID: <53BF961E.10406@broadcom.com> References: <1404980258-30853-1-git-send-email-teg@jklm.no> <1404980258-30853-30-git-send-email-teg@jklm.no> <53BEF2A6.6050103@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev , LKML , David Miller , David Herrmann , Kay Sievers , Brett Rudley , "Franky (Zhenhui) Lin" , Hante Meuleman , John Linville , "Linux Wireless List" , To: Tom Gundersen Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10-07-14 22:24, Tom Gundersen wrote: > On Thu, Jul 10, 2014 at 10:08 PM, Arend van Spriel wrote: >> On 10-07-14 10:17, Tom Gundersen wrote: >>> The name is given by the firmware, so we assume it is predictable. >> >> How about the scenario where one would have multiple broadcom wifi >> devices in the system. Both driver instances would alloc_netdev with >> predictable but also the same ifname. Wondering whether we should ignore >> the firmware ifname altogether. > > Hm, that would just fail irrespective of this patch, right? Sounds > like ignoring the firmware names is the right thing to do. True. I realized that when starting to type my reply. I think at the moment we never run into the scenario that trigger this code path. Will make a separate patch for that. Probably on top of your changes. Regards, Arend > Cheers, > > Tom >