From: Daniel Borkmann <dborkman@redhat.com>
To: Christoph Schulz <develop@kristov.de>
Cc: Varka Bhadram <varkabhadram@gmail.com>,
netdev@vger.kernel.org, linux-ppp@vger.kernel.org,
paulus@samba.org, isdn@linux-pingi.de
Subject: Re: [PATCH net 1/1] net: ppp: fix creating PPP pass and active filters
Date: Tue, 15 Jul 2014 08:59:24 +0200 [thread overview]
Message-ID: <53C4D14C.607@redhat.com> (raw)
In-Reply-To: <20140715065458.15013qglk08wv3mq@kristov.noip.me>
On 07/15/2014 06:54 AM, Christoph Schulz wrote:
> Hello!
>
> Daniel Borkmann schrieb am Sun, 13 Jul 2014 20:51:45 +0200:
>
>> I think going with the first variant is just fine.
>
> Well, then I need not change anything, do I? This first variant causes checkpatch to warn twice about a line exceeding 80 characters:
>
> WARNING: line over 80 characters
> #83: FILE: drivers/net/ppp/ppp_generic.c:771:
> + err = sk_unattached_filter_create(&ppp->pass_filter,
>
> WARNING: line over 80 characters
> #102: FILE: drivers/net/ppp/ppp_generic.c:797:
> + err = sk_unattached_filter_create(&ppp->active_filter,
>
> But I don't see how to shorten them. This is because "sk_unattached_filter_create" is such a long identifier...
Well, this is a soft-limit, and in this particular circumstance
it should be fine to use your original proposal. I don't see how
Varka's suggestions make this better in _any way_, rather the
very opposite.
next prev parent reply other threads:[~2014-07-15 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-13 12:59 [PATCH net 1/1] net: ppp: fix creating PPP pass and active filters Christoph Schulz
2014-07-13 14:54 ` Varka Bhadram
2014-07-13 16:07 ` Christoph Schulz
2014-07-13 18:51 ` Daniel Borkmann
2014-07-15 4:54 ` Christoph Schulz
2014-07-15 5:18 ` Varka Bhadram
2014-07-15 6:35 ` Christoph Schulz
2014-07-15 6:59 ` Daniel Borkmann [this message]
2014-07-15 15:38 ` Alexei Starovoitov
2014-07-16 18:47 ` Christoph Schulz
2014-07-16 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4D14C.607@redhat.com \
--to=dborkman@redhat.com \
--cc=develop@kristov.de \
--cc=isdn@linux-pingi.de \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).