From: Nikolay Aleksandrov <nikolay@redhat.com>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] bonding: fix bond_option_mode_set warning
Date: Tue, 15 Jul 2014 16:13:49 +0200 [thread overview]
Message-ID: <53C5371D.9060003@redhat.com> (raw)
In-Reply-To: <1405433337-8806-1-git-send-email-nikolay@redhat.com>
On 07/15/2014 04:08 PM, Nikolay Aleksandrov wrote:
> During the conversion to "static" functions this one got left out, only its
> prototype was converted, thus resulting in:
> drivers/net/bonding//bond_options.c:674:5: warning: symbol
> 'bond_option_mode_set' was not declared. Should it be static?
>
> Fix it by making it static and also break the line in two as it was too
> long.
>
> CC: Stephen Hemminger <stephen@networkplumber.org>
> CC: Jay Vosburgh <j.vosburgh@gmail.com>
> CC: Veaceslav Falico <vfalico@gmail.com>
> CC: Andy Gospodarek <andy@greyhouse.net>
> CC: David S. Miller <davem@davemloft.net>
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
> ---
Just FYI, I targeted this at net-next as it's more cosmetic and there aren't any
real side-effects because of it. In case you decide it's more appropriate for
-net, the commit that did this was:
f3253339a47f ("bonding: options handling cleanup")
and I tested that this patch applies cleanly to -net, so it's fit for there too.
Cheers,
Nik
next prev parent reply other threads:[~2014-07-15 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-15 14:08 [PATCH net-next] bonding: fix bond_option_mode_set warning Nikolay Aleksandrov
2014-07-15 14:13 ` Nikolay Aleksandrov [this message]
2014-07-16 5:56 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C5371D.9060003@redhat.com \
--to=nikolay@redhat.com \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).